Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-06 Thread Alan Stern
On Mon, Oct 05, 2020 at 09:25:44PM -0400, st...@rowland.harvard.edu wrote: > On Mon, Oct 05, 2020 at 11:19:02PM +, Harley A.W. Lorenzo wrote: > > On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee > > wrote: > > > > > find_tt() can return NULL or the error value in ERR_PTR() and > > > deref

Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-06 Thread gre...@linuxfoundation.org
On Mon, Oct 05, 2020 at 11:19:02PM +, Harley A.W. Lorenzo wrote: > On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee > wrote: > > > find_tt() can return NULL or the error value in ERR_PTR() and > > dereferencing the return value without checking for the error can > > lead to a possible der

Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-05 Thread st...@rowland.harvard.edu
On Mon, Oct 05, 2020 at 11:19:02PM +, Harley A.W. Lorenzo wrote: > On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee > wrote: > > > find_tt() can return NULL or the error value in ERR_PTR() and > > dereferencing the return value without checking for the error can > > lead to a possible der

Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-05 Thread Harley A.W. Lorenzo
On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee wrote: > find_tt() can return NULL or the error value in ERR_PTR() and > dereferencing the return value without checking for the error can > lead to a possible dereference of NULL pointer or ERR_PTR(). Looks fine to me. There is in fact no che

[PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-05 Thread Sudip Mukherjee
find_tt() can return NULL or the error value in ERR_PTR() and dereferencing the return value without checking for the error can lead to a possible dereference of NULL pointer or ERR_PTR(). Signed-off-by: Sudip Mukherjee --- drivers/usb/host/ehci-sched.c | 4 1 file changed, 4 insertions(+)