Re: [PATCH] tty: Remove dead termiox code

2020-12-08 Thread Jiri Slaby
On 08. 12. 20, 12:13, Christoph Hellwig wrote: On Fri, Dec 04, 2020 at 09:20:39AM +0100, Jiri Slaby wrote: Delete this dead code; but leave the definition of struct termiox in the UAPI headers intact. I am thinking -- can/should we mark the structure as deprecated so that userspace stops using

Re: [PATCH] tty: Remove dead termiox code

2020-12-08 Thread Christoph Hellwig
On Fri, Dec 04, 2020 at 09:20:39AM +0100, Jiri Slaby wrote: > > > > Delete this dead code; but leave the definition of struct termiox in the > > > > UAPI headers intact. > > > > > > I am thinking -- can/should we mark the structure as deprecated so that > > > userspace stops using it eventually? >

Re: [PATCH] tty: Remove dead termiox code

2020-12-07 Thread Greg Kroah-Hartman
On Mon, Dec 07, 2020 at 11:19:04AM +0100, Adam Borowski wrote: > On Fri, Dec 04, 2020 at 10:10:16AM +0100, Greg Kroah-Hartman wrote: > > On Fri, Dec 04, 2020 at 09:51:07AM +0100, Jiri Slaby wrote: > > > > > > On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > > > > > > > On 03. 12. 20, 3

Re: [PATCH] tty: Remove dead termiox code

2020-12-07 Thread Adam Borowski
On Fri, Dec 04, 2020 at 10:10:16AM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 04, 2020 at 09:51:07AM +0100, Jiri Slaby wrote: > > > > > On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > > > > > > On 03. 12. 20, 3:03, Jann Horn wrote: > > > > > > > Delete this dead code; but leave th

Re: [PATCH] tty: Remove dead termiox code

2020-12-04 Thread Greg Kroah-Hartman
On Fri, Dec 04, 2020 at 09:51:07AM +0100, Jiri Slaby wrote: > On 04. 12. 20, 9:36, Greg Kroah-Hartman wrote: > > On Fri, Dec 04, 2020 at 09:20:39AM +0100, Jiri Slaby wrote: > > > On 04. 12. 20, 9:17, Greg Kroah-Hartman wrote: > > > > On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > > >

Re: [PATCH] tty: Remove dead termiox code

2020-12-04 Thread Jiri Slaby
On 04. 12. 20, 9:36, Greg Kroah-Hartman wrote: On Fri, Dec 04, 2020 at 09:20:39AM +0100, Jiri Slaby wrote: On 04. 12. 20, 9:17, Greg Kroah-Hartman wrote: On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: On 03. 12. 20, 3:03, Jann Horn wrote: set_termiox() and the TCGETX handler bail

Re: [PATCH] tty: Remove dead termiox code

2020-12-04 Thread Greg Kroah-Hartman
On Fri, Dec 04, 2020 at 09:20:39AM +0100, Jiri Slaby wrote: > On 04. 12. 20, 9:17, Greg Kroah-Hartman wrote: > > On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > > > On 03. 12. 20, 3:03, Jann Horn wrote: > > > > set_termiox() and the TCGETX handler bail out with -EINVAL immediately > >

Re: [PATCH] tty: Remove dead termiox code

2020-12-04 Thread Jiri Slaby
On 04. 12. 20, 9:17, Greg Kroah-Hartman wrote: On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: On 03. 12. 20, 3:03, Jann Horn wrote: set_termiox() and the TCGETX handler bail out with -EINVAL immediately if ->termiox is NULL, but there are no code paths that can set ->termiox to a n

Re: [PATCH] tty: Remove dead termiox code

2020-12-04 Thread Greg Kroah-Hartman
On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > On 03. 12. 20, 3:03, Jann Horn wrote: > > set_termiox() and the TCGETX handler bail out with -EINVAL immediately > > if ->termiox is NULL, but there are no code paths that can set > > ->termiox to a non-NULL pointer; and no such code pat

Re: [PATCH] tty: Remove dead termiox code

2020-12-03 Thread Jiri Slaby
On 03. 12. 20, 3:03, Jann Horn wrote: set_termiox() and the TCGETX handler bail out with -EINVAL immediately if ->termiox is NULL, but there are no code paths that can set ->termiox to a non-NULL pointer; and no such code paths seem to have existed since the termiox mechanism was introduced back

Re: [PATCH] tty: Remove dead termiox code

2020-12-03 Thread Greg Kroah-Hartman
On Thu, Dec 03, 2020 at 03:03:31AM +0100, Jann Horn wrote: > set_termiox() and the TCGETX handler bail out with -EINVAL immediately > if ->termiox is NULL, but there are no code paths that can set > ->termiox to a non-NULL pointer; and no such code paths seem to have > existed since the termiox mec

[PATCH] tty: Remove dead termiox code

2020-12-02 Thread Jann Horn
set_termiox() and the TCGETX handler bail out with -EINVAL immediately if ->termiox is NULL, but there are no code paths that can set ->termiox to a non-NULL pointer; and no such code paths seem to have existed since the termiox mechanism was introduced back in commit 1d65b4a088de ("tty: Add termio