Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-22 Thread Jiri Olsa
On Mon, Dec 22, 2014 at 10:10:02AM -0700, David Ahern wrote: > On 12/22/14 10:01 AM, Jiri Olsa wrote: > >apart from your tracepoints, is there another tracepoint using this? > >I couldn't find any.. I dont think it's a problem.. just wanted to > >try it;-) > > grrr... i was hoping no one would ask

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-22 Thread David Ahern
On 12/22/14 10:01 AM, Jiri Olsa wrote: apart from your tracepoints, is there another tracepoint using this? I couldn't find any.. I dont think it's a problem.. just wanted to try it;-) grrr... i was hoping no one would ask that question. I am not aware of any in tree. We use it locally in cust

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-22 Thread Jiri Olsa
On Thu, Dec 18, 2014 at 06:41:58PM -0700, David Ahern wrote: > On 12/18/14 3:13 PM, David Ahern wrote: > >Are you seeing something different? > > I put a tracepoint in the ipv4/ipv6 add/del address code. The IPv4 one > prints the address using pi4 and pI4 and the IPv6 using pi6, pI6 and pI6c. apa

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread David Ahern
On 12/18/14 3:13 PM, David Ahern wrote: Are you seeing something different? I put a tracepoint in the ipv4/ipv6 add/del address code. The IPv4 one prints the address using pi4 and pI4 and the IPv6 using pi6, pI6 and pI6c. Using ifconfig eth1 1.2.3.4/24 I get this for trace_pipe which uses t

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread David Ahern
On 12/18/14 3:16 PM, Arnaldo Carvalho de Melo wrote: If take the time to look at the specifics I'll propose something more concrete, meanwhile, are you ok with David's changes? May I process his patch? I need a v3 to respond to oversights noted responding to Valdis. Any other comments before I

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 18, 2014 at 11:27:15AM -0500, Steven Rostedt escreveu: > On Thu, 18 Dec 2014 12:52:55 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Thu, Dec 18, 2014 at 08:10:43AM -0700, David Ahern escreveu: > > > Adds helper for following kernel formats: > > > %pi4 print an IPv4 address with l

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread David Ahern
On 12/18/14 2:45 PM, valdis.kletni...@vt.edu wrote: On Thu, 18 Dec 2014 08:10:43 -0700, David Ahern said: Adds helper for following kernel formats: %pi4 print an IPv4 address with leading zeros %pI4 print an IPv4 address without leading zeros %pi6 print an IPv6 address without colons

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread Valdis . Kletnieks
On Thu, 18 Dec 2014 08:10:43 -0700, David Ahern said: > Adds helper for following kernel formats: > %pi4 print an IPv4 address with leading zeros > %pI4 print an IPv4 address without leading zeros > %pi6 print an IPv6 address without colons > %pI6 print an IPv6 address with colons > %pI6c

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread Steven Rostedt
On Thu, 18 Dec 2014 12:52:55 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 18, 2014 at 08:10:43AM -0700, David Ahern escreveu: > > Adds helper for following kernel formats: > > %pi4 print an IPv4 address with leading zeros > > %pI4 print an IPv4 address without leading zeros > > %pi6

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread David Ahern
On 12/18/14 8:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Dec 18, 2014 at 08:10:43AM -0700, David Ahern escreveu: Adds helper for following kernel formats: %pi4 print an IPv4 address with leading zeros %pI4 print an IPv4 address without leading zeros %pi6 print an IPv6 address withou

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 18, 2014 at 08:10:43AM -0700, David Ahern escreveu: > Adds helper for following kernel formats: > %pi4 print an IPv4 address with leading zeros > %pI4 print an IPv4 address without leading zeros > %pi6 print an IPv6 address without colons > %pI6 print an IPv6 address with colons

[PATCH] tools lib traceevent: Add support for IP address formats

2014-12-18 Thread David Ahern
Adds helper for following kernel formats: %pi4 print an IPv4 address with leading zeros %pI4 print an IPv4 address without leading zeros %pi6 print an IPv6 address without colons %pI6 print an IPv6 address with colons %pI6c print an IPv6 address with colons %pISpc print an IP address fr

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-17 Thread Namhyung Kim
On Wed, Dec 17, 2014 at 09:32:27PM -0700, David Ahern wrote: > On 12/17/14 9:26 PM, Namhyung Kim wrote: > > > >It'd be better if we do it like below.. > > > > char i = *ptr++; > > > >Why not passing ptr + 1 to print_ip_arg()? > > > > That parsing loop is a bit weird - and deep. And I only want

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-17 Thread David Ahern
On 12/17/14 9:26 PM, Namhyung Kim wrote: It'd be better if we do it like below.. char i = *ptr++; Why not passing ptr + 1 to print_ip_arg()? That parsing loop is a bit weird - and deep. And I only wanted to consume 'pi' and 'pI' with parse_ip_arg if and only if the next letters ar

Re: [PATCH] tools lib traceevent: Add support for IP address formats

2014-12-17 Thread Namhyung Kim
Hi David, On Wed, Dec 17, 2014 at 01:29:08PM -0700, David Ahern wrote: > Adds helper for following kernel formats: > %pi4 print an IPv4 address with leading zeros > %pI4 print an IPv4 address without leading zeros > %pi6 print an IPv6 address without colons > %pI6 print an IPv6 address wit

[PATCH] tools lib traceevent: Add support for IP address formats

2014-12-17 Thread David Ahern
Adds helper for following kernel formats: %pi4 print an IPv4 address with leading zeros %pI4 print an IPv4 address without leading zeros %pi6 print an IPv6 address without colons %pI6 print an IPv6 address with colons %pI6c print an IPv6 address with colons %pISpc print an IP address fr