On Wed, Dec 17, 2014 at 09:32:27PM -0700, David Ahern wrote: > On 12/17/14 9:26 PM, Namhyung Kim wrote: > > > >It'd be better if we do it like below.. > > > > char i = *ptr++; > > > >Why not passing ptr + 1 to print_ip_arg()? > > > > That parsing loop is a bit weird - and deep. And I only wanted to consume > 'pi' and 'pI' with parse_ip_arg if and only if the next letters are '4', '6' > and 'S'.
Yeah, I know - but I still think you can pass ptr + 1 (but not update ptr) since everytime you only access to ptr + 1 unless I missed it. Consuming ptr depends on the return value so it's irrelevant whether you pass ptr or (ptr + 1) IMHO. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
