Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

2015-01-16 Thread Jeremiah Mahler
Jia He, Your patch is looking better :-) A few nits though. On Fri, Jan 16, 2015 at 04:58:12PM +0800, Jia He wrote: > These functions kportal_memhog_{alloc,free} aren't used outside of ^ Don't indent paragraphs, just use a line between paragraphs. > this file, so making them static to supp

[PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

2015-01-16 Thread Jia He
These functions kportal_memhog_{alloc,free} aren't used outside of this file, so making them static to suppress the sparse warnings about static declaration. Besides, this also fixes the space warning checked by checkpatch.pl Signed-off-by: Jia He Cc: Jeremiah Mahler Cc: Oleg Drokin Cc: A

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

2015-01-13 Thread Jeremiah Mahler
Jia He, On Tue, Dec 16, 2014 at 10:39:38PM +0800, Jia He wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > spelling: s/fuchtion/function/ Not sure if "make sparse happy" is the best way to describe what you are doing. You are fi

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

2015-01-13 Thread hejianet
Hi all Ping again, any comments are welcome Justin On Tue, 16 Dec 2014 22:39:38 +0800 from hejia...@gmail.com wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > > Signed-off-by: Jia He > Cc: Oleg Drokin > Cc: Andreas Dilger > Cc

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

2014-12-28 Thread hejianet
Ping. Thanks for any comments On Tue, 16 Dec 2014 22:39:38 +0800 from hejia...@gmail.com wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > > Signed-off-by: Jia He > Cc: Oleg Drokin > Cc: Andreas Dilger > Cc: Greg Kroah-Hartman

[PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

2014-12-16 Thread Jia He
make sparse happy since these two fuchtion are only used in module.c. tested by successful compilation. Signed-off-by: Jia He Cc: Oleg Drokin Cc: Andreas Dilger Cc: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/libcfs/module.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)