Jia He, On Tue, Dec 16, 2014 at 10:39:38PM +0800, Jia He wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > spelling: s/fuchtion/function/
Not sure if "make sparse happy" is the best way to describe what you are doing. You are fixing sparse warnings. [...] > -void > -kportal_memhog_free (struct libcfs_device_userstate *ldu) > +static void kportal_memhog_free (struct libcfs_device_userstate *ldu) You might as well fix the checkpatch warning created by this line too. [...] These functions aren't used outside of this file so making them static looks correct. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
