Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-24 Thread Bin Meng
Hi Mika, On Mon, Oct 23, 2017 at 8:12 PM, Mika Westerberg wrote: > On Sun, Oct 15, 2017 at 09:38:57PM +0800, Bin Meng wrote: >> > Also, the 'depends on EXPERT' statement looks misplaced, >> > enabling EXPERT should only be there to allow you to turn >> > extra things *off*, not to hide device dri

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-23 Thread Mika Westerberg
On Sun, Oct 15, 2017 at 09:38:57PM +0800, Bin Meng wrote: > > Also, the 'depends on EXPERT' statement looks misplaced, > > enabling EXPERT should only be there to allow you to turn > > extra things *off*, not to hide device drivers. > > > > I will leave this to Mika to comment the "EXPERT" usage.

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-16 Thread Arnd Bergmann
On Sun, Oct 15, 2017 at 3:38 PM, Bin Meng wrote: > On Fri, Oct 13, 2017 at 7:15 PM, Arnd Bergmann wrote:>> On > Wed, Oct 11, 2017 at 10:03 AM, Cyrille Pitchen >> warning: (SPI_INTEL_SPI_PLATFORM && ITCO_WDT) selects LPC_ICH which >> has unmet direct dependencies (HAS_IOMEM && PCI) >> drivers/mfd

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-15 Thread Bin Meng
Hi Arnd, On Fri, Oct 13, 2017 at 7:15 PM, Arnd Bergmann wrote: > On Wed, Oct 11, 2017 at 10:03 AM, Cyrille Pitchen > wrote: >> Le 25/08/2017 à 10:12, Bin Meng a écrit : >>> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform >>> data. Select it in the Kconfig. >>> >>> Signed-off

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-13 Thread Cyrille Pitchen
Hi Arnd, Le 13/10/2017 à 13:15, Arnd Bergmann a écrit : > On Wed, Oct 11, 2017 at 10:03 AM, Cyrille Pitchen > wrote: >> Le 25/08/2017 à 10:12, Bin Meng a écrit : >>> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform >>> data. Select it in the Kconfig. >>> >>> Signed-off-by: Bin

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-13 Thread Arnd Bergmann
On Wed, Oct 11, 2017 at 10:03 AM, Cyrille Pitchen wrote: > Le 25/08/2017 à 10:12, Bin Meng a écrit : >> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform >> data. Select it in the Kconfig. >> >> Signed-off-by: Bin Meng > > Applied to the spi-nor/next branch of l2-mtd This caus

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-10-11 Thread Cyrille Pitchen
Le 25/08/2017 à 10:12, Bin Meng a écrit : > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform > data. Select it in the Kconfig. > > Signed-off-by: Bin Meng Applied to the spi-nor/next branch of l2-mtd Thanks! > --- > > drivers/mtd/spi-nor/Kconfig | 1 + > 1 file changed, 1

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-08-27 Thread Mika Westerberg
On Fri, Aug 25, 2017 at 08:11:54PM +0800, Bin Meng wrote: > Other LPC_ICH users (like gpio, watchdog) use the 'select' logic, so I > would prefer to keep things consistent. Fair enough. Acked-by: Mika Westerberg

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-08-25 Thread Stefan Roese
On 25.08.2017 12:40, Mika Westerberg wrote: On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote: The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform data. Select it in the Kconfig. Signed-off-by: Bin Meng --- drivers/mtd/spi-nor/Kconfig | 1 + 1 file changed, 1 insert

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-08-25 Thread Bin Meng
Hi Mika, On Fri, Aug 25, 2017 at 6:40 PM, Mika Westerberg wrote: > On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote: >> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform >> data. Select it in the Kconfig. >> >> Signed-off-by: Bin Meng >> --- >> >> drivers/mtd/spi-nor/

Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-08-25 Thread Mika Westerberg
On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote: > The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform > data. Select it in the Kconfig. > > Signed-off-by: Bin Meng > --- > > drivers/mtd/spi-nor/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/

[PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

2017-08-25 Thread Bin Meng
The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform data. Select it in the Kconfig. Signed-off-by: Bin Meng --- drivers/mtd/spi-nor/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig index bfdfb1e..e998800 10064