Hi Mika, On Fri, Aug 25, 2017 at 6:40 PM, Mika Westerberg <mika.westerb...@linux.intel.com> wrote: > On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote: >> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform >> data. Select it in the Kconfig. >> >> Signed-off-by: Bin Meng <bmeng...@gmail.com> >> --- >> >> drivers/mtd/spi-nor/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig >> index bfdfb1e..e998800 100644 >> --- a/drivers/mtd/spi-nor/Kconfig >> +++ b/drivers/mtd/spi-nor/Kconfig >> @@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM >> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT >> depends on X86 >> select SPI_INTEL_SPI >> + select LPC_ICH > > How about > > depends on X86 && LPC_ICH > > instead?
Other LPC_ICH users (like gpio, watchdog) use the 'select' logic, so I would prefer to keep things consistent. Regards, Bin
