Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-15 Thread Phil Auld
On Fri, Aug 09, 2019 at 06:43:09PM +0100 Valentin Schneider wrote: > On 09/08/2019 14:33, Phil Auld wrote: > > On Tue, Aug 06, 2019 at 03:03:34PM +0200 Peter Zijlstra wrote: > >> On Thu, Aug 01, 2019 at 09:37:49AM -0400, Phil Auld wrote: > >>> Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_f

Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-09 Thread Valentin Schneider
On 09/08/2019 14:33, Phil Auld wrote: > On Tue, Aug 06, 2019 at 03:03:34PM +0200 Peter Zijlstra wrote: >> On Thu, Aug 01, 2019 at 09:37:49AM -0400, Phil Auld wrote: >>> Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_features causes >> >> ISTR there were more issues; but it sure is good to st

Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-09 Thread Phil Auld
On Tue, Aug 06, 2019 at 03:03:34PM +0200 Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 09:37:49AM -0400, Phil Auld wrote: > > Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_features causes > > ISTR there were more issues; but it sure is good to start picking them > off. > Following up o

Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-06 Thread Phil Auld
On Tue, Aug 06, 2019 at 03:03:34PM +0200 Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 09:37:49AM -0400, Phil Auld wrote: > > Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_features causes > > ISTR there were more issues; but it sure is good to start picking them > off. I haven't hit any

Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-06 Thread Peter Zijlstra
On Thu, Aug 01, 2019 at 09:37:49AM -0400, Phil Auld wrote: > Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_features causes ISTR there were more issues; but it sure is good to start picking them off. > warning to fire in update_rq_clock. This seems to be caused by onlining > a new fair sch

Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-06 Thread Phil Auld
On Tue, Aug 06, 2019 at 02:04:16PM +0800 Hillf Danton wrote: > > On Mon, 5 Aug 2019 22:07:05 +0800 Phil Auld wrote: > > > > If we're to clear that flag right there, outside of the lock pinning code, > > then I think we might as well just remove the flag and all associated > > comments etc, no? >

Re: [PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-05 Thread Phil Auld
On Fri, Aug 02, 2019 at 05:20:38PM +0800 Hillf Danton wrote: > > On Thu, 1 Aug 2019 09:37:49 -0400 Phil Auld wrote: > > > > Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_features causes > > warning to fire in update_rq_clock. This seems to be caused by onlining > > a new fair sched group

[PATCH] sched: use rq_lock/unlock in online_fair_sched_group

2019-08-01 Thread Phil Auld
Enabling WARN_DOUBLE_CLOCK in /sys/kernel/debug/sched_features causes warning to fire in update_rq_clock. This seems to be caused by onlining a new fair sched group not using the rq lock wrappers. [472978.683085] rq->clock_update_flags & RQCF_UPDATED [472978.683100] WARNING: CPU: 5 PID: 54385 at k