On Tue, Aug 06, 2019 at 02:04:16PM +0800 Hillf Danton wrote: > > On Mon, 5 Aug 2019 22:07:05 +0800 Phil Auld wrote: > > > > If we're to clear that flag right there, outside of the lock pinning code, > > then I think we might as well just remove the flag and all associated > > comments etc, no? > > A diff may tell the Peter folks more about your thoughts? >
I provided a diff with my thoughts of how to remove this warning in the original post :) This comment was about your patch which, to my mind, makes the flag meaningless and so could just remove the whole thing. I was not proposing to actually do that. I assumed it was there because it was thought to be useful. Although, if that is what people want I could certainly spin up a patch to that effect. Cheers, Phil > Hillf > --