Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function

2015-08-12 Thread Alexandre Belloni
gt; > -Original Message- > > From: Wang Dongsheng-B40534 > > Sent: Wednesday, July 15, 2015 10:06 AM > > To: 'Alexandre Belloni' > > Cc: a.zu...@towertech.it; rtc-li...@googlegroups.com; linux- > > ker...@vger.kernel.org > > Subject: RE: [PATCH] rtc/d

RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function

2015-08-12 Thread Wang Dongsheng
u...@towertech.it; rtc-li...@googlegroups.com; linux- > ker...@vger.kernel.org > Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume > function > > Thanks Belloni. :) > > Regards, > -Dongsheng > > > -Original Message- > > From: Alexandr

RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function

2015-07-14 Thread Wang Dongsheng
..@vger.kernel.org > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume > function > > Hi, > > This seems ok, one small nitpick: > > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote : > > From: Wang Dongsheng diff --git > > a/dri

Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function

2015-07-14 Thread Alexandre Belloni
Hi, This seems ok, one small nitpick: On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote : > From: Wang Dongsheng > diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c > index 7e48e53..2081155 100644 > --- a/drivers/rtc/rtc-ds3232.c > +++ b/drivers/rtc/rtc-ds3232.c > @@ -463,7 +4

[PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function

2015-07-06 Thread Dongsheng Wang
From: Wang Dongsheng If ds3232 work on some platform that is not implementation irq_set_wake, ds3232 will get a WARNING trace in resume. So fix ds3232->suspended state to false when irq_set_irq_wake return error. [ cut here ] WARNING: CPU: 0 PID: 729 at kernel/irq/manage.