Hi,
This seems ok, one small nitpick:
On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> From: Wang Dongsheng <dongsheng.w...@freescale.com>
> diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c
> index 7e48e53..2081155 100644
> --- a/drivers/rtc/rtc-ds3232.c
> +++ b/drivers/rtc/rtc-ds3232.c
> @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
>
> if (device_can_wakeup(dev)) {
> ds3232->suspended = true;
> - irq_set_irq_wake(client->irq, 1);
> + if (irq_set_irq_wake(client->irq, 1)) {
> + dev_info(dev, "Cannot serve as a wakeup source\n");
I would use dev_warn_once or dev_info_once here to avoid spamming the
log each time the machine is suspended.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
