Re: [PATCH] regulator: core: Assign bool value to variable has_full_constraints

2016-07-04 Thread Mark Brown
On Mon, Jul 04, 2016 at 04:38:26PM +0800, Baoquan He wrote: > By the way, I still think it makes code more read-able to assign a bool > value to a bool variable. In your words, C truly has full support for > using integers in a boolean context, then commit 21cf891a is not > necessary to be made to

Re: [PATCH] regulator: core: Assign bool value to variable has_full_constraints

2016-07-04 Thread Baoquan He
On 07/04/16 at 10:12am, Mark Brown wrote: > On Mon, Jul 04, 2016 at 10:05:25AM +0800, Baoquan He wrote: > > > In commit 21cf891a (regulator: Make regulator_has_full_constraints a bool) > > type of variable has_full_constraints is changed to bool, so assign 'true' > > to has_full_constraints here.

Re: [PATCH] regulator: core: Assign bool value to variable has_full_constraints

2016-07-04 Thread Baoquan He
On 07/04/16 at 10:12am, Mark Brown wrote: > On Mon, Jul 04, 2016 at 10:05:25AM +0800, Baoquan He wrote: > > > In commit 21cf891a (regulator: Make regulator_has_full_constraints a bool) > > type of variable has_full_constraints is changed to bool, so assign 'true' > > to has_full_constraints here.

Re: [PATCH] regulator: core: Assign bool value to variable has_full_constraints

2016-07-04 Thread Mark Brown
On Mon, Jul 04, 2016 at 10:05:25AM +0800, Baoquan He wrote: > In commit 21cf891a (regulator: Make regulator_has_full_constraints a bool) > type of variable has_full_constraints is changed to bool, so assign 'true' > to has_full_constraints here. There is no need to make changes like this, C has f

[PATCH] regulator: core: Assign bool value to variable has_full_constraints

2016-07-03 Thread Baoquan He
In commit 21cf891a (regulator: Make regulator_has_full_constraints a bool) type of variable has_full_constraints is changed to bool, so assign 'true' to has_full_constraints here. Signed-off-by: Baoquan He --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -