On 07/04/16 at 10:12am, Mark Brown wrote: > On Mon, Jul 04, 2016 at 10:05:25AM +0800, Baoquan He wrote: > > > In commit 21cf891a (regulator: Make regulator_has_full_constraints a bool) > > type of variable has_full_constraints is changed to bool, so assign 'true' > > to has_full_constraints here. > > There is no need to make changes like this, C has full support for using > integers in a boolean context - using true here would've been just as > meaningful with an integer variable and using a number for a boolean > variable is fully equivalent.
By the way, I still think it makes code more read-able to assign a bool value to a bool variable. In your words, C truly has full support for using integers in a boolean context, then commit 21cf891a is not necessary to be made to change.
