On Thu, Aug 11, 2016 at 01:48:21PM -0700, Tim Harvey wrote:
> regulators must have a non-null ops field or they will fail
> registration so I can't just not assign it. What would be an
> appropriate ops structure for a always-on fixed regulator?
OK, empty is fine there.
signature.asc
Descriptio
On Thu, Aug 11, 2016 at 2:45 AM, Mark Brown wrote:
> On Wed, Aug 10, 2016 at 05:44:55PM -0700, Tim Harvey wrote:
>> On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown wrote:
>
>> >> +/* LDO1 always on fixed 0.8V-3.3V via scalar via R1/R2 feeback res */
>> >> +static struct regulator_ops ltc3676_fixed_st
On Wed, Aug 10, 2016 at 05:44:55PM -0700, Tim Harvey wrote:
> On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown wrote:
> >> +/* LDO1 always on fixed 0.8V-3.3V via scalar via R1/R2 feeback res */
> >> +static struct regulator_ops ltc3676_fixed_standby_regulator_ops = {
> >> +};
> > Remove this, it's po
On Wed, Aug 10, 2016 at 3:28 PM, Rob Herring wrote:
> On Tue, Aug 09, 2016 at 04:36:07PM -0700, Tim Harvey wrote:
>> This patch adds support for the Linear Technology LTC3676
>> 8-output I2C voltage regulator IC.
>>
>> Cc: Jaffer Kapasi
>> Signed-off-by: Tim Harvey
>> ---
>> .../devicetree/bind
On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown wrote:
> On Tue, Aug 09, 2016 at 04:36:07PM -0700, Tim Harvey wrote:
>
> Mostly looks good but quite a few issues with not using framework
> features here, a lot of the code can be factored out into the core:
>
Mark,
thanks for the review!
>> + /*
On Tue, Aug 09, 2016 at 04:36:07PM -0700, Tim Harvey wrote:
> This patch adds support for the Linear Technology LTC3676
> 8-output I2C voltage regulator IC.
>
> Cc: Jaffer Kapasi
> Signed-off-by: Tim Harvey
> ---
> .../devicetree/bindings/regulator/ltc3676.txt | 94
Acked-by: Rob Her
On Tue, Aug 09, 2016 at 04:36:07PM -0700, Tim Harvey wrote:
Mostly looks good but quite a few issues with not using framework
features here, a lot of the code can be factored out into the core:
> + /* DVB reference select is bit5 of DVBA reg */
> + mask = 1 << 5;
> +
> + if (mode != R
This patch adds support for the Linear Technology LTC3676
8-output I2C voltage regulator IC.
Cc: Jaffer Kapasi
Signed-off-by: Tim Harvey
---
.../devicetree/bindings/regulator/ltc3676.txt | 94
drivers/regulator/Kconfig | 8 +
drivers/regulator/Makefile
8 matches
Mail list logo
