Re: [PATCH] perf, tools, stat: Fix perf stat -T

2015-07-28 Thread Andi Kleen
> > I'm not talking about it being urgent or not, I'm talking about it being > > a bug present only in perf/core or if this is something that is in > > perf/urgent, i.e. affects what is in Linus's upstream tree, etc. > > ah ok, it affects perf/urgent as well I think there are some more typos in t

Re: [PATCH] perf, tools, stat: Fix perf stat -T

2015-07-28 Thread Jiri Olsa
On Tue, Jul 28, 2015 at 11:32:57AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 28, 2015 at 04:30:18PM +0200, Jiri Olsa escreveu: > > On Tue, Jul 28, 2015 at 11:21:32AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Jul 28, 2015 at 04:10:06PM +0200, Jiri Olsa escreveu: > > > > On Mon,

Re: [PATCH] perf, tools, stat: Fix perf stat -T

2015-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2015 at 04:30:18PM +0200, Jiri Olsa escreveu: > On Tue, Jul 28, 2015 at 11:21:32AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 28, 2015 at 04:10:06PM +0200, Jiri Olsa escreveu: > > > On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote: > > > > +++ b/tools/perf/util

Re: [PATCH] perf, tools, stat: Fix perf stat -T

2015-07-28 Thread Jiri Olsa
On Tue, Jul 28, 2015 at 11:21:32AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 28, 2015 at 04:10:06PM +0200, Jiri Olsa escreveu: > > On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > The transaction length metrics in perf stat -T broke recentl

Re: [PATCH] perf, tools, stat: Fix perf stat -T

2015-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2015 at 04:10:06PM +0200, Jiri Olsa escreveu: > On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > The transaction length metrics in perf stat -T broke recently. > > It would not match the metric correctly and always print K/sec. > > This was

Re: [PATCH] perf, tools, stat: Fix perf stat -T

2015-07-28 Thread Jiri Olsa
On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote: > From: Andi Kleen > > The transaction length metrics in perf stat -T broke recently. > It would not match the metric correctly and always print K/sec. > This was caused by a incorrect update of the cycles_in_tx statistics. > Update the

[PATCH] perf, tools, stat: Fix perf stat -T

2015-07-27 Thread Andi Kleen
From: Andi Kleen The transaction length metrics in perf stat -T broke recently. It would not match the metric correctly and always print K/sec. This was caused by a incorrect update of the cycles_in_tx statistics. Update the correct variable. Also the check for zero division was reversed, which