Re: [PATCH] mm: Add unlikely for current_order test

2013-06-17 Thread Zhang Yanfei
On 06/18/2013 05:37 AM, David Rientjes wrote: > On Mon, 17 Jun 2013, Zhang Yanfei wrote: > >>> I don't understand the justification at all, current_order being unlikely >>> greater than or equal to pageblock_order / 2 doesn't imply at all that >>> it's unlikely that current_order is greater than

Re: [PATCH] mm: Add unlikely for current_order test

2013-06-17 Thread David Rientjes
On Mon, 17 Jun 2013, Zhang Yanfei wrote: > > I don't understand the justification at all, current_order being unlikely > > greater than or equal to pageblock_order / 2 doesn't imply at all that > > it's unlikely that current_order is greater than or equal to > > pageblock_order. > > > > hmmm.

Re: [PATCH] mm: Add unlikely for current_order test

2013-06-16 Thread Zhang Yanfei
Hi David, On 06/17/2013 02:04 AM, David Rientjes wrote: > On Sat, 15 Jun 2013, Zhang Yanfei wrote: > >> From: Zhang Yanfei >> >> Since we have an unlikely for the "current_order >= pageblock_order / 2" >> test above, adding an unlikely for this "current_order >= pageblock_order" >> test seems mo

Re: [PATCH] mm: Add unlikely for current_order test

2013-06-16 Thread David Rientjes
On Sat, 15 Jun 2013, Zhang Yanfei wrote: > From: Zhang Yanfei > > Since we have an unlikely for the "current_order >= pageblock_order / 2" > test above, adding an unlikely for this "current_order >= pageblock_order" > test seems more appropriate. > I don't understand the justification at all,

[PATCH] mm: Add unlikely for current_order test

2013-06-15 Thread Zhang Yanfei
From: Zhang Yanfei Since we have an unlikely for the "current_order >= pageblock_order / 2" test above, adding an unlikely for this "current_order >= pageblock_order" test seems more appropriate. Signed-off-by: Zhang Yanfei --- mm/page_alloc.c |2 +- 1 files changed, 1 insertions(+), 1 del