Re: [PATCH] mm/zswap: change params from hidden to ro

2013-12-13 Thread Dan Streetman
On Fri, Nov 22, 2013 at 12:21 PM, Seth Jennings wrote: > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >> The "compressor" and "enabled" params are currently hidden, >> this changes them to read-only, so userspace can tell if >> zswap is enabled or not and see what compressor is i

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-24 Thread Vladimir Murzin
On Fri, Nov 22, 2013 at 12:18:01PM -0500, Dan Streetman wrote: > On Fri, Nov 22, 2013 at 2:38 AM, Vladimir Murzin wrote: > > On Wed, Nov 20, 2013 at 12:52:47PM -0500, Dan Streetman wrote: > On Wed, Nov > > 20, 2013 at 12:33 PM, Vladimir Murzin wrote: > > Hi > > Dan! > >> > > >> > On Wed, Nov 20,

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-22 Thread Seth Jennings
On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: > The "compressor" and "enabled" params are currently hidden, > this changes them to read-only, so userspace can tell if > zswap is enabled or not and see what compressor is in use. Reasonable to me. Acked-by: Seth Jennings > > Sig

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-22 Thread Dan Streetman
On Fri, Nov 22, 2013 at 2:38 AM, Vladimir Murzin wrote: > On Wed, Nov 20, 2013 at 12:52:47PM -0500, Dan Streetman wrote: > On Wed, Nov > 20, 2013 at 12:33 PM, Vladimir Murzin wrote: > > Hi Dan! >> > >> > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >> >> The "compressor" and "en

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-21 Thread Vladimir Murzin
On Wed, Nov 20, 2013 at 12:52:47PM -0500, Dan Streetman wrote: > On Wed, Nov 20, 2013 at 12:33 PM, Vladimir Murzin wrote: > > Hi Dan! > > > > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: > >> The "compressor" and "enabled" params are currently hidden, > >> this changes them to re

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-20 Thread Weijie Yang
On Thu, Nov 21, 2013 at 1:52 AM, Dan Streetman wrote: > On Wed, Nov 20, 2013 at 12:33 PM, Vladimir Murzin wrote: >> Hi Dan! >> >> On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >>> The "compressor" and "enabled" params are currently hidden, >>> this changes them to read-only, so u

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-20 Thread Dan Streetman
On Wed, Nov 20, 2013 at 12:33 PM, Vladimir Murzin wrote: > Hi Dan! > > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >> The "compressor" and "enabled" params are currently hidden, >> this changes them to read-only, so userspace can tell if >> zswap is enabled or not and see what c

Re: [PATCH] mm/zswap: change params from hidden to ro

2013-11-20 Thread Vladimir Murzin
Hi Dan! On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: > The "compressor" and "enabled" params are currently hidden, > this changes them to read-only, so userspace can tell if > zswap is enabled or not and see what compressor is in use. Could you elaborate more why this pice of in