Hi Dan! On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: > The "compressor" and "enabled" params are currently hidden, > this changes them to read-only, so userspace can tell if > zswap is enabled or not and see what compressor is in use.
Could you elaborate more why this pice of information is necessary for userspace? Vladimir > > Signed-off-by: Dan Streetman <ddstr...@ieee.org> > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index d93510c..36b268b 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -77,12 +77,12 @@ static u64 zswap_duplicate_entry; > **********************************/ > /* Enable/disable zswap (disabled by default, fixed at boot for now) */ > static bool zswap_enabled __read_mostly; > -module_param_named(enabled, zswap_enabled, bool, 0); > +module_param_named(enabled, zswap_enabled, bool, 0444); > > /* Compressor to be used by zswap (fixed at boot for now) */ > #define ZSWAP_COMPRESSOR_DEFAULT "lzo" > static char *zswap_compressor = ZSWAP_COMPRESSOR_DEFAULT; > -module_param_named(compressor, zswap_compressor, charp, 0); > +module_param_named(compressor, zswap_compressor, charp, 0444); > > /* The maximum percentage of memory that the compressed pool can occupy */ > static unsigned int zswap_max_pool_percent = 20; > -- > 1.8.3.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"d...@kvack.org";> em...@kvack.org </a> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
