Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-09 Thread Paul E. McKenney
On Thu, Nov 09, 2017 at 08:19:25AM -0800, Davidlohr Bueso wrote: > On Wed, 08 Nov 2017, Paul E. McKenney wrote: > > >Jeremy, could you please test Dave's patches and make sure that they > >work for you? That way I can apply your Tested-by. Dave, any objection > >to my adding Jeremy's Reported-by

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-09 Thread Davidlohr Bueso
On Wed, 08 Nov 2017, Paul E. McKenney wrote: Jeremy, could you please test Dave's patches and make sure that they work for you? That way I can apply your Tested-by. Dave, any objection to my adding Jeremy's Reported-by to your /201 patch? No, feel free. Thanks, Davidlohr

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-09 Thread Jeremy Linton
Hi, On 11/08/2017 11:44 AM, Paul E. McKenney wrote: On Wed, Nov 08, 2017 at 10:57:07AM -0600, Jeremy Linton wrote: On 11/08/2017 10:48 AM, Paul E. McKenney wrote: On Wed, Nov 08, 2017 at 06:45:23AM -0800, Davidlohr Bueso wrote: On Tue, 07 Nov 2017, Paul E. McKenney wrote: On Tue, Nov 07, 20

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Paul E. McKenney
On Wed, Nov 08, 2017 at 10:57:07AM -0600, Jeremy Linton wrote: > On 11/08/2017 10:48 AM, Paul E. McKenney wrote: > >On Wed, Nov 08, 2017 at 06:45:23AM -0800, Davidlohr Bueso wrote: > >>On Tue, 07 Nov 2017, Paul E. McKenney wrote: > >> > >>>On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wr

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Jeremy Linton
On 11/08/2017 10:48 AM, Paul E. McKenney wrote: On Wed, Nov 08, 2017 at 06:45:23AM -0800, Davidlohr Bueso wrote: On Tue, 07 Nov 2017, Paul E. McKenney wrote: On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wrote: On Tue, Nov 07, 2017 at 02:01:58PM -0600, Jeremy Linton wrote: Hi, On

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Paul E. McKenney
On Wed, Nov 08, 2017 at 06:45:23AM -0800, Davidlohr Bueso wrote: > On Tue, 07 Nov 2017, Paul E. McKenney wrote: > > >On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wrote: > >>On Tue, Nov 07, 2017 at 02:01:58PM -0600, Jeremy Linton wrote: > >>> Hi, > >>> > >>> On 10/10/2017 10:52 AM, Jere

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Davidlohr Bueso
On Tue, 07 Nov 2017, Paul E. McKenney wrote: On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wrote: On Tue, Nov 07, 2017 at 02:01:58PM -0600, Jeremy Linton wrote: > Hi, > > On 10/10/2017 10:52 AM, Jeremy Linton wrote: > >If nwriters_stress=0 is passed to the lock torture test > >it wil

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Paul E. McKenney
On Wed, Nov 08, 2017 at 09:27:50AM +0100, Peter Zijlstra wrote: > On Tue, Nov 07, 2017 at 02:15:55PM -0800, Paul E. McKenney wrote: > > But Jeremy's list of email addresses is what you would expect from > > looking at MAINTAINERS, so how about the following patch? > > True; I tend to also look at

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Peter Zijlstra
On Tue, Nov 07, 2017 at 02:15:55PM -0800, Paul E. McKenney wrote: > But Jeremy's list of email addresses is what you would expect from > looking at MAINTAINERS, so how about the following patch? True; I tend to also look at git history (as goes get_maintainers.pl IIRC). > commit 58322063498c8f5a3

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-07 Thread Paul E. McKenney
On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wrote: > On Tue, Nov 07, 2017 at 02:01:58PM -0600, Jeremy Linton wrote: > > Hi, > > > > On 10/10/2017 10:52 AM, Jeremy Linton wrote: > > >If nwriters_stress=0 is passed to the lock torture test > > >it will panic in: > > > > Ping? > > > >

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-07 Thread Peter Zijlstra
On Tue, Nov 07, 2017 at 02:01:58PM -0600, Jeremy Linton wrote: > Hi, > > On 10/10/2017 10:52 AM, Jeremy Linton wrote: > >If nwriters_stress=0 is passed to the lock torture test > >it will panic in: > > Ping? > > Has anyone had a chance to look at this? Helps if you Cc the people actually workin

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-07 Thread Jeremy Linton
Hi, On 10/10/2017 10:52 AM, Jeremy Linton wrote: If nwriters_stress=0 is passed to the lock torture test it will panic in: Ping? Has anyone had a chance to look at this? Thanks, Internal error: Oops: 9605 [#1] SMP ... [] __torture_print_stats+0x2c/0x1c8 [locktorture] [] lock_torture_s

[PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-10-10 Thread Jeremy Linton
If nwriters_stress=0 is passed to the lock torture test it will panic in: Internal error: Oops: 9605 [#1] SMP ... [] __torture_print_stats+0x2c/0x1c8 [locktorture] [] lock_torture_stats_print+0x74/0x120 [locktorture] [] lock_torture_stats+0x40/0xa8 [locktorture] [] kthread+0x108/0x138 [] ret_f