Re: [PATCH] locks: remove trailing semicolon in macro definition

2020-11-29 Thread Joe Perches
On Sun, 2020-11-29 at 10:15 -0800, James Bottomley wrote: > I think nowadays we should always use static inlines for argument > checking unless we're capturing debug information like __FILE__ or > __LINE__ or something that a static inline can't. IMO: __LINE__ should never be used. __func__ is th

Re: [PATCH] locks: remove trailing semicolon in macro definition

2020-11-29 Thread James Bottomley
On Sun, 2020-11-29 at 09:52 -0800, Randy Dunlap wrote: > On 11/29/20 9:47 AM, Tom Rix wrote: > > On 11/27/20 11:53 AM, Matthew Wilcox wrote: > > > On Fri, Nov 27, 2020 at 11:07:07AM -0800, t...@redhat.com wrote: > > > > +++ b/fs/fcntl.c > > > > @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned

Re: [PATCH] locks: remove trailing semicolon in macro definition

2020-11-29 Thread Randy Dunlap
On 11/29/20 9:47 AM, Tom Rix wrote: > > On 11/27/20 11:53 AM, Matthew Wilcox wrote: >> On Fri, Nov 27, 2020 at 11:07:07AM -0800, t...@redhat.com wrote: >>> +++ b/fs/fcntl.c >>> @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned >>> int, cmd, >>> (dst)->l_whence = (src)->l

Re: [PATCH] locks: remove trailing semicolon in macro definition

2020-11-29 Thread Tom Rix
On 11/27/20 11:53 AM, Matthew Wilcox wrote: > On Fri, Nov 27, 2020 at 11:07:07AM -0800, t...@redhat.com wrote: >> +++ b/fs/fcntl.c >> @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, >> cmd, >> (dst)->l_whence = (src)->l_whence; \ >> (dst)->l_start = (s

Re: [PATCH] locks: remove trailing semicolon in macro definition

2020-11-27 Thread Matthew Wilcox
On Fri, Nov 27, 2020 at 11:07:07AM -0800, t...@redhat.com wrote: > +++ b/fs/fcntl.c > @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, > cmd, > (dst)->l_whence = (src)->l_whence; \ > (dst)->l_start = (src)->l_start;\ > (dst)->l_len = (src)

[PATCH] locks: remove trailing semicolon in macro definition

2020-11-27 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- fs/fcntl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fcntl.c b/fs/fcntl.c index 05b36b28f2e8..96a65758c498 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -526,7 +526,7 @@ SYSCALL_DEF