On Fri, Nov 27, 2020 at 11:07:07AM -0800, t...@redhat.com wrote:
> +++ b/fs/fcntl.c
> @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, 
> cmd,
>       (dst)->l_whence = (src)->l_whence;      \
>       (dst)->l_start = (src)->l_start;        \
>       (dst)->l_len = (src)->l_len;            \
> -     (dst)->l_pid = (src)->l_pid;
> +     (dst)->l_pid = (src)->l_pid

This should be wrapped in a do { } while (0).

Look, this warning is clearly great at finding smelly code, but the
fixes being generated to shut up the warning are low quality.

Reply via email to