Re: [PATCH] lockd and nfsd endianness annotation fixes

2007-07-26 Thread Al Viro
On Thu, Jul 26, 2007 at 09:19:22PM -0400, J. Bruce Fields wrote: > Thanks, uh, I probably saw that message too. > > Hm, trying it just now--it catches the svclock.c mistake, but not the > one in nfsd/nfs4xdr.c--at least not as far as I can tell. fs/nfsd/nfs4xdr.c:2659:32: warning: incorrect typ

Re: [PATCH] lockd and nfsd endianness annotation fixes

2007-07-26 Thread J. Bruce Fields
On Fri, Jul 27, 2007 at 10:11:41AM +1000, Neil Brown wrote: > On Thursday July 26, [EMAIL PROTECTED] wrote: > > On Thu, Jul 26, 2007 at 05:33:49PM +0100, Al Viro wrote: > > > > > > > Oops, thanks; these are my fault. > > > > (How are you finding these? I was assuming sparse, but running a make

Re: [PATCH] lockd and nfsd endianness annotation fixes

2007-07-26 Thread Neil Brown
On Thursday July 26, [EMAIL PROTECTED] wrote: > On Thu, Jul 26, 2007 at 05:33:49PM +0100, Al Viro wrote: > > > > Oops, thanks; these are my fault. > > (How are you finding these? I was assuming sparse, but running a make > -C2 just now I didn't see anything that would have suggested these > fix

Re: [PATCH] lockd and nfsd endianness annotation fixes

2007-07-26 Thread J. Bruce Fields
On Thu, Jul 26, 2007 at 05:33:49PM +0100, Al Viro wrote: > Oops, thanks; these are my fault. (How are you finding these? I was assuming sparse, but running a make -C2 just now I didn't see anything that would have suggested these fixes. I'm using whatever's current in Fedora--it says 0.3-1.fc7

[PATCH] lockd and nfsd endianness annotation fixes

2007-07-26 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- fs/lockd/svclock.c |6 +++--- fs/nfsd/nfs4xdr.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c index b3efa45..a21e4bc 100644 --- a/fs/lockd/svclock.c +++ b/fs/lockd/svclock.c @@