On Fri, Jul 27, 2007 at 10:11:41AM +1000, Neil Brown wrote: > On Thursday July 26, [EMAIL PROTECTED] wrote: > > On Thu, Jul 26, 2007 at 05:33:49PM +0100, Al Viro wrote: > > > > > > > Oops, thanks; these are my fault. > > > > (How are you finding these? I was assuming sparse, but running a make > > -C2 just now I didn't see anything that would have suggested these > > fixes. I'm using whatever's current in Fedora--it says 0.3-1.fc7. Do I > > need something more recent?) > > I have a note about that somewhere..... > > > From: Al Viro <[EMAIL PROTECTED]> > > Subject: Re: [PATCHSET] nfs endianness annotations > > Date: Thu, 19 Oct 2006 02:26:00 +0100 > > .... > > > > Folks, seriously, please run sparse after changes; it's a simple matter of > > make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; nothing tricky and it saves a lot > > of potential PITA... > > And with lots of good intentions, I ran this about once, and promptly > forgot.
Thanks, uh, I probably saw that message too. Hm, trying it just now--it catches the svclock.c mistake, but not the one in nfsd/nfs4xdr.c--at least not as far as I can tell. --b. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
