Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-23 Thread Greg Kroah-Hartman
On Mon, Mar 22, 2021 at 07:03:45PM +0100, Arnd Bergmann wrote: > On Mon, Mar 22, 2021 at 6:03 PM Daniel Thompson > wrote: > > > > > > Acked-by: Daniel Thompson > > > > Which tree do you want to merge this one though? I've got nothing else > > pending for this file so I am very relaxed about the r

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 9:14 PM Jason Wessel wrote: > > The original board this was developed with was a 32bit eeepc. > > The intent was that when v2printk() was called for a verbose > 1 > condition the touch_nmi_watchdog() was called. The test case > where a whole lot of single steps are execut

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Jason Wessel
On 3/22/21 2:22 PM, Doug Anderson wrote: Hi, On Mon, Mar 22, 2021 at 11:19 AM Arnd Bergmann wrote: On Mon, Mar 22, 2021 at 6:07 PM Doug Anderson wrote: On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: -#define v1printk(a...) do { \ - if (verbose) \ - printk(KER

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Daniel Thompson
On Mon, Mar 22, 2021 at 10:04:57AM -0700, Doug Anderson wrote: > > + if (verbose)\ > > + printk(KERN_INFO a);\ > > +} while (0) > > +#define v2printk(a...) do {\ > > + if (verbose > 1)\ > > + printk(KERN_INF

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Doug Anderson
Hi, On Mon, Mar 22, 2021 at 11:19 AM Arnd Bergmann wrote: > > On Mon, Mar 22, 2021 at 6:07 PM Doug Anderson wrote: > > On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: > > > > > > -#define v1printk(a...) do { \ > > > - if (verbose) \ > > > - printk(KERN_INFO a); \ > > >

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 6:07 PM Doug Anderson wrote: > On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: > > > > -#define v1printk(a...) do { \ > > - if (verbose) \ > > - printk(KERN_INFO a); \ > > - } while (0) > > -#define v2printk(a...) do { \ > > - if (verbo

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 6:03 PM Daniel Thompson wrote: > > > Acked-by: Daniel Thompson > > Which tree do you want to merge this one though? I've got nothing else > pending for this file so I am very relaxed about the route... I don't plan to merge any of the build fixes through my own tree. If y

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Doug Anderson
Hi, On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: > > -#define v1printk(a...) do { \ > - if (verbose) \ > - printk(KERN_INFO a); \ > - } while (0) > -#define v2printk(a...) do { \ > - if (verbose > 1) \ > - printk(KERN_INFO a); \ > -

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Daniel Thompson
On Mon, Mar 22, 2021 at 05:43:03PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 starts warning about misleading indentation inside of macros: > > drivers/misc/kgdbts.c: In function ‘kgdbts_break_test’: > drivers/misc/kgdbts.c:103:9: error: this ‘if’ clause does not guard... > [-

[PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 starts warning about misleading indentation inside of macros: drivers/misc/kgdbts.c: In function ‘kgdbts_break_test’: drivers/misc/kgdbts.c:103:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 103 | if (verbose > 1) \ |