Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-20 Thread Chen Gang
On 06/20/2013 05:13 PM, Thomas Gleixner wrote: > On Thu, 20 Jun 2013, Chen Gang wrote: >> > On 06/20/2013 03:47 PM, Thomas Gleixner wrote: >> > --- >> > If we assume "If there is nothing in tv2 which might come before the >

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-20 Thread Thomas Gleixner
On Thu, 20 Jun 2013, Chen Gang wrote: > On 06/20/2013 03:47 PM, Thomas Gleixner wrote: > --- > If we assume "If there is nothing in tv2 which might come before the > found timer, then any timer in tv3 will ..." is correct.

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-20 Thread Chen Gang
On 06/20/2013 03:47 PM, Thomas Gleixner wrote: > On Tue, 18 Jun 2013, Chen Gang wrote: >> > On 06/10/2013 10:12 PM, Thomas Gleixner wrote: >> > I think we can treat original implementation as for speed optimization, >> > so our discussion is "whether this speed optimization has effect with >> > cor

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-20 Thread Thomas Gleixner
On Tue, 18 Jun 2013, Chen Gang wrote: > On 06/10/2013 10:12 PM, Thomas Gleixner wrote: > I think we can treat original implementation as for speed optimization, > so our discussion is "whether this speed optimization has effect with > correctness". Then I recommend that you to sit down and analyze

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-18 Thread Chen Gang
On 06/10/2013 10:12 PM, Thomas Gleixner wrote: > On Sun, 9 Jun 2013, Chen Gang wrote: > >> >> According to __internal_add_timer(), in _next_timer_interrupt(), when >> 'tv1.vec' find one, but need 'cascade bucket(s)', we still need find >> each slot of 'tv*.vec'. > > No, we do not. We only need to

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-17 Thread Chen Gang
Sorry again for replying late, and now I can focus on this patch, I will see the related details again. Thanks. On 06/13/2013 11:39 AM, Chen Gang wrote: > > Sorry for replying late during these days, firstly. > > > On 06/10/2013 10:12 PM, Thomas Gleixner wrote: >> On Sun, 9 Jun 2013, Chen Ga

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-12 Thread Chen Gang
Sorry for replying late during these days, firstly. On 06/10/2013 10:12 PM, Thomas Gleixner wrote: > On Sun, 9 Jun 2013, Chen Gang wrote: > >> > >> > According to __internal_add_timer(), in _next_timer_interrupt(), when >> > 'tv1.vec' find one, but need 'cascade bucket(s)', we still need find

Re: [PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-10 Thread Thomas Gleixner
On Sun, 9 Jun 2013, Chen Gang wrote: > > According to __internal_add_timer(), in _next_timer_interrupt(), when > 'tv1.vec' find one, but need 'cascade bucket(s)', we still need find > each slot of 'tv*.vec'. No, we do not. We only need to scan the first cascade array after the enqueued timer. If

[PATCH] kernel: timer: looping issue, need reset variable 'found'

2013-06-09 Thread Chen Gang
According to __internal_add_timer(), in _next_timer_interrupt(), when 'tv1.vec' find one, but need 'cascade bucket(s)', we still need find each slot of 'tv*.vec'. So need reset variable 'found', so can fully scan ''do {...} while()'' for 'tv*.vec'. Signed-off-by: Chen Gang --- kernel/timer.c