Re: [PATCH] io: accel: kxcjk-1013: Fix iio_event_spec direction

2014-11-03 Thread Jonathan Cameron
On 18/10/14 12:57, Jonathan Cameron wrote: > On 10/10/14 15:53, Daniel Baluta wrote: >> Because IIO_EV_DIR_* are not bitmasks but enums, >> IIO_EV_DIR_RISING | IIO_EV_DIR_FALLING is not equal >> with IIO_EV_DIR_EITHER. >> >> This could lead to potential misformatted sysfs attributes >> like: >>

Re: [PATCH] io: accel: kxcjk-1013: Fix iio_event_spec direction

2014-10-18 Thread Jonathan Cameron
On 10/10/14 15:53, Daniel Baluta wrote: > Because IIO_EV_DIR_* are not bitmasks but enums, > IIO_EV_DIR_RISING | IIO_EV_DIR_FALLING is not equal > with IIO_EV_DIR_EITHER. > > This could lead to potential misformatted sysfs attributes > like: > * in_accel_x_thresh_(null)_en > * in_accel

[PATCH] io: accel: kxcjk-1013: Fix iio_event_spec direction

2014-10-10 Thread Daniel Baluta
Because IIO_EV_DIR_* are not bitmasks but enums, IIO_EV_DIR_RISING | IIO_EV_DIR_FALLING is not equal with IIO_EV_DIR_EITHER. This could lead to potential misformatted sysfs attributes like: * in_accel_x_thresh_(null)_en * in_accel_x_thresh_(null)_period * in_accel_x_thresh_