Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-25 Thread Rob Landley
On Friday 24 August 2007 5:46:51 pm Jeff Dike wrote: > On Fri, Aug 24, 2007 at 03:51:41PM -0500, Rob Landley wrote: > > It may be non-urgent to you, but it still broke my build. :) > > > > Acked-by: Rob Landley <[EMAIL PROTECTED]> > > Heh, it doesn't seem like -stable material to me, but if there a

Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-25 Thread Rob Landley
On Friday 24 August 2007 7:20:27 pm Andrew Morton wrote: > On Fri, 24 Aug 2007 14:46:16 -0400 > > Jeff Dike <[EMAIL PROTECTED]> wrote: > > [ This looks non-urgent to me ] > > > > Without linux/pagemap.h, asm-generic/tlb.h is missing declarations of > > page_cache_release and release_pages. > > > >

Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Andrew Morton
On Fri, 24 Aug 2007 22:15:33 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > > So I think a better fix would be better, but I'm not able to suggest what, > > as there is little detail about the failure here and I can find no mention > > of page_cache_release and release_pages in asm-generic/tlb.h. P

Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Jeff Dike
On Fri, Aug 24, 2007 at 05:20:27PM -0700, Andrew Morton wrote: > This is worrisome. If you look at pagemap.h, it includes a pile of things > which could easily themsleves try to include tlb.h via some path or > another. I fear that this patch will cause explosions with some config > and/or archit

Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Andrew Morton
On Fri, 24 Aug 2007 14:46:16 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > [ This looks non-urgent to me ] > > Without linux/pagemap.h, asm-generic/tlb.h is missing declarations of > page_cache_release and release_pages. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> > -- > include/asm-generic

Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Jeff Dike
On Fri, Aug 24, 2007 at 03:51:41PM -0500, Rob Landley wrote: > It may be non-urgent to you, but it still broke my build. :) > > Acked-by: Rob Landley <[EMAIL PROTECTED]> Heh, it doesn't seem like -stable material to me, but if there aren't any screams while it sits in -mm, maybe it's 2.6.23 mater

Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Rob Landley
On Friday 24 August 2007 1:46:16 pm Jeff Dike wrote: > [ This looks non-urgent to me ] > > Without linux/pagemap.h, asm-generic/tlb.h is missing declarations of > page_cache_release and release_pages. It may be non-urgent to you, but it still broke my build. :) Acked-by: Rob Landley <[EMAIL PROTE

[PATCH] include linux/pagemap.h in asm-generic/tlb.h

2007-08-24 Thread Jeff Dike
[ This looks non-urgent to me ] Without linux/pagemap.h, asm-generic/tlb.h is missing declarations of page_cache_release and release_pages. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/asm-generic/tlb.h |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.22/include/asm-generic/