On Fri, 24 Aug 2007 22:15:33 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote:
> > So I think a better fix would be better, but I'm not able to suggest what,
> > as there is little detail about the failure here and I can find no mention
> > of page_cache_release and release_pages in asm-generic/tlb.h. Presumably
> > they're getting pulled in via some macro and then instantiated in some
> > inline function or something?
>
> Yes, it's straightforward -
>
> tlb.h:
>
> static inline void
> tlb_flush_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
> {
> ...
> free_pages_and_swap_cache(tlb->pages, tlb->nr);
> ...
> }
>
> swap.h:
> #define free_pages_and_swap_cache(pages, nr) \
> release_pages((pages), (nr), 0);
Oh that damn thing again. It's a regular source of include breakage.
I suppose we could just uninline tlb_flush_mmu().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
