Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-04 Thread Jean Delvare
On Wed, 3 Dec 2014 11:14:46 -0800, Guenter Roeck wrote: > A quick glance into Lauchpad shows that i8kutils is still maintained > and used, including the sometimes dirty tricks it provides. Don't draw conclusions too fast though... People may just not have realized that they no longer need it. Old

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-03 Thread Guenter Roeck
On Wed, Dec 03, 2014 at 10:09:28AM +0100, Jean Delvare wrote: > Hi Guenter, > > On Tue, 02 Dec 2014 06:26:29 -0800, Guenter Roeck wrote: > > On 12/02/2014 05:23 AM, Jean Delvare wrote: > > > Ultimately /proc/i8k should be killed altogether and every function > > > should use the appropriate standa

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-03 Thread Jean Delvare
On Wed, 03 Dec 2014 10:25:26 +0100, Pali Rohár wrote: > Anyway, what does i8k mean? That dell interface is somehow called DELLDIAG, > so I do not know what i8k means... I think i8k stands for "Inspiron 8000", most likely the first model supported by that driver: http://www.dell.com/support/home/u

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-03 Thread Pali Rohár
On Wed Dec  3 10:09:28 2014 Jean Delvare wrote: > Hi Guenter, > > On Tue, 02 Dec 2014 06:26:29 -0800, Guenter Roeck wrote: > > On 12/02/2014 05:23 AM, Jean Delvare wrote: > > > Ultimately /proc/i8k should be killed altogether and every function > > > should use the appropriate standard interface

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-03 Thread Jean Delvare
Hi Guenter, On Tue, 02 Dec 2014 06:26:29 -0800, Guenter Roeck wrote: > On 12/02/2014 05:23 AM, Jean Delvare wrote: > > Ultimately /proc/i8k should be killed altogether and every function > > should use the appropriate standard interface. But I don't have any Dell > > laptop around so I won't go in

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-02 Thread Guenter Roeck
On 12/02/2014 05:23 AM, Jean Delvare wrote: Hi Pali, hi Greg, Le Saturday 29 November 2014 à 19:04 +0100, Pali Rohár a écrit : On Saturday 29 November 2014 18:51:52 Greg Kroah-Hartman wrote: On Sat, Nov 29, 2014 at 06:49:43PM +0100, Pali Rohár wrote: On Saturday 29 November 2014 18:43:15 Greg

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-02 Thread Jean Delvare
Hi Pali, hi Greg, Le Saturday 29 November 2014 à 19:04 +0100, Pali Rohár a écrit : > On Saturday 29 November 2014 18:51:52 Greg Kroah-Hartman wrote: > > On Sat, Nov 29, 2014 at 06:49:43PM +0100, Pali Rohár wrote: > > > On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: > > > > No Docu

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Guenter Roeck
On 11/30/2014 10:00 AM, Pali Rohár wrote: [ ...] Yes, you are right. I will create new patches. Hi Pali, When doing so, please watch out for line lengths. Some of your previous patches created lines with more than 80 characters per line. Thanks, Guenter -- To unsubscribe from this list: se

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Pali Rohár
On Sunday 30 November 2014 18:54:21 Guenter Roeck wrote: > On 11/30/2014 09:44 AM, Pali Rohár wrote: > > On Sunday 30 November 2014 17:00:18 Guenter Roeck wrote: > >> On 11/30/2014 01:53 AM, Pali Rohár wrote: > >> [ ... ] > >> > > Original Dell DOS executable ignores all temperature > > se

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Guenter Roeck
On 11/30/2014 09:44 AM, Pali Rohár wrote: On Sunday 30 November 2014 17:00:18 Guenter Roeck wrote: On 11/30/2014 01:53 AM, Pali Rohár wrote: [ ... ] Original Dell DOS executable ignores all temperature sensors if type SMM function fails (if I decoded and understand that DOS assembler code corr

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Pali Rohár
On Sunday 30 November 2014 17:00:18 Guenter Roeck wrote: > On 11/30/2014 01:53 AM, Pali Rohár wrote: > [ ... ] > > >>> Original Dell DOS executable ignores all temperature > >>> sensors if type SMM function fails (if I decoded and > >>> understand that DOS assembler code correctly). So maybe > >>>

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Guenter Roeck
On 11/30/2014 02:11 AM, Pali Rohár wrote: On Sunday 30 November 2014 02:25:09 Guenter Roeck wrote: On 11/29/2014 11:07 AM, Pali Rohár wrote: [ ... ] Original Dell DOS executable ignores all temperature sensors if type SMM function fails (if I decoded and understand that DOS assembler code corr

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Guenter Roeck
On 11/30/2014 01:53 AM, Pali Rohár wrote: [ ... ] Original Dell DOS executable ignores all temperature sensors if type SMM function fails (if I decoded and understand that DOS assembler code correctly). So maybe we should do same... But because our i8k.c code ignores sensor only if it returns i

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Pali Rohár
On Sunday 30 November 2014 02:25:09 Guenter Roeck wrote: > On 11/29/2014 11:07 AM, Pali Rohár wrote: > [ ... ] > > > Original Dell DOS executable ignores all temperature sensors > > if type SMM function fails (if I decoded and understand > > that DOS assembler code correctly). So maybe we should d

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-30 Thread Pali Rohár
On Sunday 30 November 2014 01:07:15 Guenter Roeck wrote: > On 11/29/2014 11:07 AM, Pali Rohár wrote: > > On Saturday 29 November 2014 19:58:28 Guenter Roeck wrote: > >> On 11/29/2014 10:27 AM, Gabriele Mazzotta wrote: > >>> On Saturday 29 November 2014 18:18:18 Pali Rohár wrote: > On Saturday

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 11:07 AM, Pali Rohár wrote: [ ... ] Original Dell DOS executable ignores all temperature sensors if type SMM function fails (if I decoded and understand that DOS assembler code correctly). So maybe we should do same... Pali, Makes me wonder - does the assembler code tell you wha

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 11:07 AM, Pali Rohár wrote: On Saturday 29 November 2014 19:58:28 Guenter Roeck wrote: On 11/29/2014 10:27 AM, Gabriele Mazzotta wrote: On Saturday 29 November 2014 18:18:18 Pali Rohár wrote: On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: On Saturday 29 November

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 11:07 AM, Pali Rohár wrote: On Saturday 29 November 2014 19:58:28 Guenter Roeck wrote: On 11/29/2014 10:27 AM, Gabriele Mazzotta wrote: On Saturday 29 November 2014 18:18:18 Pali Rohár wrote: On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: On Saturday 29 November

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 19:58:28 Guenter Roeck wrote: > On 11/29/2014 10:27 AM, Gabriele Mazzotta wrote: > > On Saturday 29 November 2014 18:18:18 Pali Rohár wrote: > >> On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: > >>> On Saturday 29 November 2014 17:09:35 Pali Rohár wrote

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 10:27 AM, Gabriele Mazzotta wrote: On Saturday 29 November 2014 18:18:18 Pali Rohár wrote: On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: On Saturday 29 November 2014 17:09:35 Pali Rohár wrote: On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: This patch ad

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Gabriele Mazzotta
On Saturday 29 November 2014 18:18:18 Pali Rohár wrote: > On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: > > On Saturday 29 November 2014 17:09:35 Pali Rohár wrote: > > > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > > > > This patch adds labels for temperature sensors i

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 08:30 AM, Pali Rohár wrote: On Saturday 29 November 2014 17:24:08 Guenter Roeck wrote: On 11/29/2014 08:04 AM, Pali Rohár wrote: +static bool __init i8k_check_temp(int sensor) +{ + int err; + + /* +* Check if temperature sensor type is valid. +* +

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 09:51 AM, Greg Kroah-Hartman wrote: On Sat, Nov 29, 2014 at 06:49:43PM +0100, Pali Rohár wrote: On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: This patch adds labels for temperature sensors if SMM functi

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 18:51:52 Greg Kroah-Hartman wrote: > On Sat, Nov 29, 2014 at 06:49:43PM +0100, Pali Rohár wrote: > > On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: > > > On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > > > > This patch adds labels for tem

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 09:43 AM, Greg Kroah-Hartman wrote: On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Greg Kroah-Hartman
On Sat, Nov 29, 2014 at 06:49:43PM +0100, Pali Rohár wrote: > On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: > > On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > > > This patch adds labels for temperature sensors if SMM > > > function with EAX register 0x11a3 reports i

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 18:43:15 Greg Kroah-Hartman wrote: > On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > > This patch adds labels for temperature sensors if SMM > > function with EAX register 0x11a3 reports it. These > > informations was taken from DOS binary NBSVC.MDM. > >

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Greg Kroah-Hartman
On Sat, Nov 29, 2014 at 05:04:07PM +0100, Pali Rohár wrote: > This patch adds labels for temperature sensors if SMM function with EAX > register > 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. > > Signed-off-by: Pali Rohár > --- > drivers/char/i8k.c | 110 > ++

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote: > On Saturday 29 November 2014 17:09:35 Pali Rohár wrote: > > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > > > This patch adds labels for temperature sensors if SMM > > > function with EAX register 0x11a3 reports it. These

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Gabriele Mazzotta
On Saturday 29 November 2014 17:09:35 Pali Rohár wrote: > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > > This patch adds labels for temperature sensors if SMM function > > with EAX register 0x11a3 reports it. These informations was > > taken from DOS binary NBSVC.MDM. > > > > Signed-o

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Steven Honeyman
On 29 November 2014 at 16:09, Pali Rohár wrote: > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: >> This patch adds labels for temperature sensors if SMM function >> with EAX register 0x11a3 reports it. These informations was >> taken from DOS binary NBSVC.MDM. >> >> Signed-off-by: Pali R

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:24:56 Guenter Roeck wrote: > On 11/29/2014 08:09 AM, Pali Rohár wrote: > > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > >> This patch adds labels for temperature sensors if SMM > >> function with EAX register 0x11a3 reports it. These > >> informations wa

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:24:08 Guenter Roeck wrote: > On 11/29/2014 08:04 AM, Pali Rohár wrote: > > +static bool __init i8k_check_temp(int sensor) > > +{ > > + int err; > > + > > + /* > > +* Check if temperature sensor type is valid. > > +* > > +* If it is valid then sensor s

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 08:09 AM, Pali Rohár wrote: On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --- drivers/

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Guenter Roeck
On 11/29/2014 08:04 AM, Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --- drivers/char/i8k.c | 110 +++

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: > This patch adds labels for temperature sensors if SMM function > with EAX register 0x11a3 reports it. These informations was > taken from DOS binary NBSVC.MDM. > > Signed-off-by: Pali Rohár > --- > drivers/char/i8k.c | 110 >

[PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár --- drivers/char/i8k.c | 110 +--- 1 file changed, 88 insertions(