Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-13 Thread Kumar Gala
On Aug 13, 2013, at 1:01 AM, Ohad Ben-Cohen wrote: > On Mon, Aug 12, 2013 at 8:24 PM, Kumar Gala wrote: >> So I think I'd ask you to recommend a name, should we just us 'hwspinlock'. >> The general view from ePAPR and dts is the node name should be a bit more >> generic (like ethernet or pci)

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Ohad Ben-Cohen
On Mon, Aug 12, 2013 at 8:24 PM, Kumar Gala wrote: > So I think I'd ask you to recommend a name, should we just us 'hwspinlock'. > The general view from ePAPR and dts is the node name should be a bit more > generic (like ethernet or pci). So what would you suggest? How about 'hwlock' ? This

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Kumar Gala
On Aug 10, 2013, at 2:11 PM, Ohad Ben-Cohen wrote: > + Grant > > On Thu, Aug 1, 2013 at 5:10 PM, Kumar Gala wrote: >>> On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: On 07/29, Kumar Gala wrote: >> diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt >> b/Documen

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Kumar Gala
On Aug 12, 2013, at 11:30 AM, Stephen Boyd wrote: > On 08/10/13 12:11, Ohad Ben-Cohen wrote: >> Otherwise, Stephen - do we have your Ack here? I was happy to see your >> review but not sure what's the latest status. > > The smp_mb() should be removed. Otherwise I'm willing to accept that we > on

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Stephen Boyd
On 08/10/13 12:11, Ohad Ben-Cohen wrote: > Otherwise, Stephen - do we have your Ack here? I was happy to see your > review but not sure what's the latest status. The smp_mb() should be removed. Otherwise I'm willing to accept that we only build this driver on ARCH_MSM for now. We can fix that in t

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-10 Thread Ohad Ben-Cohen
+ Grant On Thu, Aug 1, 2013 at 5:10 PM, Kumar Gala wrote: >> On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: >>> On 07/29, Kumar Gala wrote: > diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt > b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt > new fil

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-01 Thread Kumar Gala
On Jul 29, 2013, at 4:54 PM, Kumar Gala wrote: > > On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: > >> On 07/29, Kumar Gala wrote: diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt new file mode 100

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-07-29 Thread Stephen Boyd
On 07/29, Kumar Gala wrote: > > On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: > > > On 07/29, Kumar Gala wrote: > >>> +#include > >>> +#include > >>> + > >>> +#include > > > > please. > > will change, I choice since *_relaxed are arm specific. > I thought readl_relaxed() was universal

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-07-29 Thread Kumar Gala
On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: > On 07/29, Kumar Gala wrote: >>> diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt >>> b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt >>> new file mode 100644 >>> index 000..ddd6889 >>> --- /dev/null >>> +++ b/

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-07-29 Thread Stephen Boyd
On 07/29, Kumar Gala wrote: > > diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt > > b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt > > new file mode 100644 > > index 000..ddd6889 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-07-29 Thread Kumar Gala
On Jul 29, 2013, at 3:11 PM, Kumar Gala wrote: > Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM > SoC (MSM8974, etc). > > CC: Jeffrey Hugo > CC: Eric Holmberg > Signed-off-by: Kumar Gala > --- [ had old device tree mailing list ] > .../devicetree/bindings/arm/msm/

[PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-07-29 Thread Kumar Gala
Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM SoC (MSM8974, etc). CC: Jeffrey Hugo CC: Eric Holmberg Signed-off-by: Kumar Gala --- .../devicetree/bindings/arm/msm/tcsr-mutex.txt | 20 +++ drivers/hwspinlock/Kconfig | 11 ++ drivers/hwsp