Re: [PATCH] gcc4 fix for sn_serial.c

2005-03-15 Thread Jesse Barnes
On Monday, March 14, 2005 5:03 pm, Adrian Bunk wrote: > > -static struct uart_driver sal_console_uart = { > > +struct uart_driver sal_console_uart = { > > .owner = THIS_MODULE, > > .driver_name = "sn_console", > > .dev_name = DEVICE_NAME, > > Why can't you solve this without making sal_consol

Re: [PATCH] gcc4 fix for sn_serial.c

2005-03-14 Thread Adrian Bunk
On Mon, Mar 14, 2005 at 11:32:39AM -0800, Jesse Barnes wrote: > The sal_console and sal_console_uart structures have a circular relationship > since they both initialize member fields to pointers of one another. The > current code forward declares sal_console_uart as extern so that sal_console

[PATCH] gcc4 fix for sn_serial.c

2005-03-14 Thread Jesse Barnes
The sal_console and sal_console_uart structures have a circular relationship since they both initialize member fields to pointers of one another. The current code forward declares sal_console_uart as extern so that sal_console can take its address, but gcc4 complains about this since the real d