The sal_console and sal_console_uart structures have a circular relationship
since they both initialize member fields to pointers of one another. The
current code forward declares sal_console_uart as extern so that sal_console
can take its address, but gcc4 complains about this since the real definition
of sal_console_uart is marked 'static'. This patch just removes the static
qualifier from sal_console_uart to avoid the inconsistency. Does it look ok
to you, Pat?
Signed-off-by: Jesse Barnes <[EMAIL PROTECTED]>
Thanks,
Jesse
===== drivers/serial/sn_console.c 1.12 vs edited =====
--- 1.12/drivers/serial/sn_console.c 2005-03-07 20:41:31 -08:00
+++ edited/drivers/serial/sn_console.c 2005-03-14 10:57:19 -08:00
@@ -801,7 +801,7 @@
#define SAL_CONSOLE &sal_console
-static struct uart_driver sal_console_uart = {
+struct uart_driver sal_console_uart = {
.owner = THIS_MODULE,
.driver_name = "sn_console",
.dev_name = DEVICE_NAME,
