Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-17 Thread Tony Lindgren
* Con Kolivas <[EMAIL PROTECTED]> [050816 06:23]: > On Tue, 16 Aug 2005 23:19, Srivatsa Vaddagiri wrote: > > On Tue, Aug 16, 2005 at 02:30:51AM +1000, Con Kolivas wrote: > > > Time definitely was lost the longer the machine was running. > > > > I think I found the reason for time drift. Basically c

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-16 Thread Con Kolivas
On Tue, 16 Aug 2005 23:19, Srivatsa Vaddagiri wrote: > On Tue, Aug 16, 2005 at 02:30:51AM +1000, Con Kolivas wrote: > > Time definitely was lost the longer the machine was running. > > I think I found the reason for time drift. Basically cur_timer->mark_offset > doesnt expect to be called from non-

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-16 Thread Srivatsa Vaddagiri
On Tue, Aug 16, 2005 at 02:30:51AM +1000, Con Kolivas wrote: > Time definitely was lost the longer the machine was running. I think I found the reason for time drift. Basically cur_timer->mark_offset doesnt expect to be called from non-timer interrupt handler. Hence it drops one jiffy from the los

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-15 Thread Srivatsa Vaddagiri
On Mon, Aug 15, 2005 at 09:39:22AM -0700, john stultz wrote: > The timer_opts interface is the existing interface, my work replaces it > and separates timekeeping from the timer interrupt. > > You can find a cumulative version of my patch here: > http://www.ussg.iu.edu/hypermail/linux/kernel/0508.

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-15 Thread john stultz
On Mon, 2005-08-15 at 21:17 +0530, Srivatsa Vaddagiri wrote: > On Sun, Aug 14, 2005 at 12:15:38AM -0400, Kyle Moffett wrote: > > It may be a good idea to rebase this patch off the new generic time- > > keeping > > subsystem that John Stultz is working on. > > I _am_ using the new subsystem interf

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-15 Thread Con Kolivas
On Tue, 16 Aug 2005 01:35, Srivatsa Vaddagiri wrote: > On Sun, Aug 14, 2005 at 10:18:28AM +1000, Con Kolivas wrote: > > timers that made no progress until interrupts drove the timers on again. > > I built in both PIT and APIC dyntick mode into the kernel and the default > > in the way I modified th

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-15 Thread Srivatsa Vaddagiri
On Sun, Aug 14, 2005 at 12:15:38AM -0400, Kyle Moffett wrote: > It may be a good idea to rebase this patch off the new generic time- > keeping > subsystem that John Stultz is working on. I _am_ using the new subsystem interface (->mark_offset) to catch up with lost ticks. Only I don't think it is

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-15 Thread Srivatsa Vaddagiri
On Sun, Aug 14, 2005 at 10:18:28AM +1000, Con Kolivas wrote: > timers that made no progress until interrupts drove the timers on again. I > built in both PIT and APIC dyntick mode into the kernel and the default in > the way I modified the patch is for APIC mode to be used if it's built in. > Af

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-13 Thread Kyle Moffett
On Aug 13, 2005, at 20:18:28, Con Kolivas wrote: It does seems there are some timing issues with this patch, although it is also quite stable (up for 10 hours now). I've had a few interesting messages in my syslog suggesting problems: Hangcheck: hangcheck value past margin! and then later on

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-13 Thread Con Kolivas
On Sun, 14 Aug 2005 02:46, Srivatsa Vaddagiri wrote: > On Sun, Aug 14, 2005 at 12:53:20AM +1000, Con Kolivas wrote: > > Indeed this fixes it on my P4 so that it does skip ticks. However > > presumably due to the code change I am having the reverse behaviour from > > previously - it pauses for ages

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-13 Thread Srivatsa Vaddagiri
On Sun, Aug 14, 2005 at 12:53:20AM +1000, Con Kolivas wrote: > Indeed this fixes it on my P4 so that it does skip ticks. However presumably > due to the code change I am having the reverse behaviour from previously - it > pauses for ages when using PIT - worse so than previously in that if I dont

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-13 Thread Con Kolivas
On Sat, 13 Aug 2005 21:37, Srivatsa Vaddagiri wrote: > On Sat, Aug 13, 2005 at 04:51:07PM +1000, Con Kolivas wrote: > > I'm sorry to say this doesn't appear to skip any ticks on my single P4 > > with SMP/SMT enabled. > > Con, > I had enabled skipping ticks only in default_idle routine. So if

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-13 Thread Srivatsa Vaddagiri
On Sat, Aug 13, 2005 at 04:51:07PM +1000, Con Kolivas wrote: > I'm sorry to say this doesn't appear to skip any ticks on my single P4 with > SMP/SMT enabled. Con, I had enabled skipping ticks only in default_idle routine. So if you have a different idle route (which I suspect is the case)

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-12 Thread Con Kolivas
On Sat, 13 Aug 2005 11:35, Con Kolivas wrote: > On Sat, 13 Aug 2005 06:19, Srivatsa Vaddagiri wrote: > > Hi, > > Here's finally the SMP changes that I had promised. The patch > > breaks the earlier restriction that all CPUs have to be idle before > > cutting of timers and now allows each idle C

Re: [ck] [PATCH] dynamic-tick patch modified for SMP

2005-08-12 Thread Con Kolivas
On Sat, 13 Aug 2005 06:19, Srivatsa Vaddagiri wrote: > Hi, > Here's finally the SMP changes that I had promised. The patch > breaks the earlier restriction that all CPUs have to be idle before > cutting of timers and now allows each idle CPU to skip ticks independent > of others. The patch is

[PATCH] dynamic-tick patch modified for SMP

2005-08-12 Thread Srivatsa Vaddagiri
Hi, Here's finally the SMP changes that I had promised. The patch breaks the earlier restriction that all CPUs have to be idle before cutting of timers and now allows each idle CPU to skip ticks independent of others. The patch is against 2.6.13-rc6 and applies on top of Con's patch main

Re: [PATCH] dynamic tick patch

2005-01-21 Thread George Anzinger
Zwane Mwaikambo wrote: Hello George, On Fri, 21 Jan 2005, George Anzinger wrote: The VST patch on sourceforge (http://sourceforge.net/projects/high-res-timers/) uses the local apic timer to do the wake up. This is the same timer that is used for the High Res work. I've been meaning to look into

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Zwane Mwaikambo
Hello George, On Fri, 21 Jan 2005, George Anzinger wrote: > The VST patch on sourceforge > (http://sourceforge.net/projects/high-res-timers/) uses the local apic timer > to do the wake up. This is the same timer that is used for the High Res work. I've been meaning to look into it, although it'

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Pavel Machek
Hi! > > > > Sorry for the delay in replaying. Thanks for pointing that out, I > > > > don't know yet what to do with the local APIC timer. Have to look at > > > > more. > > > > > > Pavel does your test system have a Local APIC? If so that may also > > > explain > > > why you didn't see a differ

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Zwane Mwaikambo
On Fri, 21 Jan 2005, Pavel Machek wrote: > > > > This doesn't seem to cover the local APIC timer, what do you do about > > > > the > > > > 1kHz tick which it's programmed to do? > > > > > > Sorry for the delay in replaying. Thanks for pointing that out, I > > > don't know yet what to do with th

Re: [PATCH] dynamic tick patch

2005-01-21 Thread George Anzinger
Zwane Mwaikambo wrote: On Fri, 21 Jan 2005, Tony Lindgren wrote: This doesn't seem to cover the local APIC timer, what do you do about the 1kHz tick which it's programmed to do? Sorry for the delay in replaying. Thanks for pointing that out, I don't know yet what to do with the local APIC timer.

Re: [PATCH] dynamic tick patch

2005-01-21 Thread George Anzinger
Tony Lindgren wrote: * George Anzinger [050120 15:10]: Tony Lindgren wrote: * George Anzinger [050119 16:25]: Tony Lindgren wrote: * George Anzinger [050119 15:00]: I don't think you will ever get good time if you EVER reprogramm the PIT. That is why the VST patch on sourceforge does NOT tou

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Pavel Machek
Hi! > > > This doesn't seem to cover the local APIC timer, what do you do about the > > > 1kHz tick which it's programmed to do? > > > > Sorry for the delay in replaying. Thanks for pointing that out, I > > don't know yet what to do with the local APIC timer. Have to look at > > more. > > Pavel

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Tony Lindgren
* Zwane Mwaikambo <[EMAIL PROTECTED]> [050121 10:27]: > On Fri, 21 Jan 2005, Tony Lindgren wrote: > > > > This doesn't seem to cover the local APIC timer, what do you do about the > > > 1kHz tick which it's programmed to do? > > > > Sorry for the delay in replaying. Thanks for pointing that out,

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Zwane Mwaikambo
On Fri, 21 Jan 2005, Tony Lindgren wrote: > > This doesn't seem to cover the local APIC timer, what do you do about the > > 1kHz tick which it's programmed to do? > > Sorry for the delay in replaying. Thanks for pointing that out, I > don't know yet what to do with the local APIC timer. Have to

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Tony Lindgren
* Zwane Mwaikambo <[EMAIL PROTECTED]> [050119 20:02]: > On Tue, 18 Jan 2005, Tony Lindgren wrote: > > > Hi all, > > > > Attached is the dynamic tick patch for x86 to play with > > as I promised in few threads earlier on this list.[1][2] > > > > The dynamic tick patch does following: > > > > - S

Re: [PATCH] dynamic tick patch

2005-01-21 Thread Tony Lindgren
* George Anzinger [050120 15:10]: > Tony Lindgren wrote: > >* George Anzinger [050119 16:25]: > > > >>Tony Lindgren wrote: > >> > >>>* George Anzinger [050119 15:00]: > >>> > >>> > I don't think you will ever get good time if you EVER reprogramm the > PIT. That is why the VST patch on s

Re: [PATCH] dynamic tick patch

2005-01-20 Thread George Anzinger
Tony Lindgren wrote: * George Anzinger [050119 16:25]: Tony Lindgren wrote: * George Anzinger [050119 15:00]: I don't think you will ever get good time if you EVER reprogramm the PIT. That is why the VST patch on sourceforge does NOT touch the PIT, it only turns off the interrupt by interrupti

Re: [PATCH] dynamic tick patch

2005-01-20 Thread Tony Lindgren
* George Anzinger [050119 16:25]: > Tony Lindgren wrote: > >* George Anzinger [050119 15:00]: > > > >>I don't think you will ever get good time if you EVER reprogramm the PIT. > >>That is why the VST patch on sourceforge does NOT touch the PIT, it only > >>turns off the interrupt by interruptin

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Pavel Machek <[EMAIL PROTECTED]> [050119 16:56]: > Hi! > > > > > > > Thanks for trying it out. I have quite accurate time here on my > > > > > > systems, and sleep works as it should. I wonder what's happening on > > > > > > your system? If you have a chance, could you please post the results >

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Thomas Gleixner
On Wed, 2005-01-19 at 15:45 -0800, john stultz wrote: > On Thu, 2005-01-20 at 00:26 +0100, Thomas Gleixner wrote: > > On Wed, 2005-01-19 at 14:59 -0800, George Anzinger wrote: > > > I don't think you will ever get good time if you EVER reprogramm the PIT. > > > > Why not ? If you have a continous

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Zwane Mwaikambo
On Tue, 18 Jan 2005, Tony Lindgren wrote: > Hi all, > > Attached is the dynamic tick patch for x86 to play with > as I promised in few threads earlier on this list.[1][2] > > The dynamic tick patch does following: > > - Separates timer interrupts from updating system time > > - Allows updating

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Valdis . Kletnieks
On Wed, 19 Jan 2005 14:59:20 PST, George Anzinger said: > allows the PIT to be the "gold standard" in time that it is designed to be. > The > wake up interrupt, then needs to come from an independent timer. My patch > requires a local APIC for this. Patch is available at > http://sourceforge

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > > > > Thanks for trying it out. I have quite accurate time here on my > > > > > systems, and sleep works as it should. I wonder what's happening on > > > > > your system? If you have a chance, could you please post the results > > > > > from following simple tests? > > > > > > > > On patc

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > > Thanks. Looks like you're running on PIT only, I guess my patch > > > currently breaks PIT (and possibly HPET) No dmesg message for " > > > "Using XXX for high-res timesource". > > > > This machine definitely has TSC... What do I have to do in .config to > > make it do something intere

Re: [PATCH] dynamic tick patch

2005-01-19 Thread George Anzinger
Thomas Gleixner wrote: On Wed, 2005-01-19 at 14:59 -0800, George Anzinger wrote: I don't think you will ever get good time if you EVER reprogramm the PIT. Why not ? If you have a continous time source, which keeps track of "ticks" regardless the CPU state, why should PIT reprogramming be evil ? Fi

Re: [PATCH] dynamic tick patch

2005-01-19 Thread George Anzinger
Tony Lindgren wrote: * George Anzinger [050119 15:00]: I don't think you will ever get good time if you EVER reprogramm the PIT. That is why the VST patch on sourceforge does NOT touch the PIT, it only turns off the interrupt by interrupting the interrupt path (not changing the PIT). This all

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Pavel Machek <[EMAIL PROTECTED]> [050119 15:58]: > Hi! > > > > > Thanks for trying it out. I have quite accurate time here on my > > > > systems, and sleep works as it should. I wonder what's happening on > > > > your system? If you have a chance, could you please post the results > > > > from f

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > > Thanks for trying it out. I have quite accurate time here on my > > > systems, and sleep works as it should. I wonder what's happening on > > > your system? If you have a chance, could you please post the results > > > from following simple tests? > > > > On patched 2.6.11-rc1: > > > >

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Pavel Machek <[EMAIL PROTECTED]> [050119 15:47]: > Hi! > > > > > > > As this patch is related to the VST/High-Res timers, there > > > > > > are probably various things that can be merged. I have not > > > > > > yet looked at what all could be merged. > > > > > > > > > > > > I'd appreciate some

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > > > > As this patch is related to the VST/High-Res timers, there > > > > > are probably various things that can be merged. I have not > > > > > yet looked at what all could be merged. > > > > > > > > > > I'd appreciate some comments and testing! > > > > > > > > Good news is that it does

Re: [PATCH] dynamic tick patch

2005-01-19 Thread john stultz
On Thu, 2005-01-20 at 00:26 +0100, Thomas Gleixner wrote: > On Wed, 2005-01-19 at 14:59 -0800, George Anzinger wrote: > > I don't think you will ever get good time if you EVER reprogramm the PIT. > > Why not ? If you have a continous time source, which keeps track of > "ticks" regardless the CPU s

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Thomas Gleixner
On Wed, 2005-01-19 at 14:59 -0800, George Anzinger wrote: > I don't think you will ever get good time if you EVER reprogramm the PIT. Why not ? If you have a continous time source, which keeps track of "ticks" regardless the CPU state, why should PIT reprogramming be evil ? tglx - To unsubscrib

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* George Anzinger [050119 15:00]: > > I don't think you will ever get good time if you EVER reprogramm the PIT. > That is why the VST patch on sourceforge does NOT touch the PIT, it only > turns off the interrupt by interrupting the interrupt path (not changing > the PIT). This allows the PIT

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Pavel Machek <[EMAIL PROTECTED]> [050119 14:06]: > Hi! > > > > > As this patch is related to the VST/High-Res timers, there > > > > are probably various things that can be merged. I have not > > > > yet looked at what all could be merged. > > > > > > > > I'd appreciate some comments and testing

Re: [PATCH] dynamic tick patch

2005-01-19 Thread George Anzinger
Andrea Arcangeli wrote: On Wed, Jan 19, 2005 at 09:13:23AM -0800, Tony Lindgren wrote: HZ=100 does not allow improving the idle loop much further from what we have. We should be able to take advantage of the longer idle/sleep periods inbetween the skipped ticks. OTOH servers aren't just doing idle

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Andrea Arcangeli
On Wed, Jan 19, 2005 at 11:34:20AM -0800, Tony Lindgren wrote: > It could be HPET that kills it. I don't have any boxes with HPET > timer, can you try without HPET? There's no hpet hardware in that system. Also the problem I'm having is not with your patch but on some code that should be exercised

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > > As this patch is related to the VST/High-Res timers, there > > > are probably various things that can be merged. I have not > > > yet looked at what all could be merged. > > > > > > I'd appreciate some comments and testing! > > > > Good news is that it does seem to reduce number of int

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > > As this patch is related to the VST/High-Res timers, there > > > are probably various things that can be merged. I have not > > > yet looked at what all could be merged. > > > > > > I'd appreciate some comments and testing! > > > > Good news is that it does seem to reduce number of int

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [050119 11:20]: > * Andrea Arcangeli <[EMAIL PROTECTED]> [050119 11:12]: > > On Wed, Jan 19, 2005 at 10:19:47AM -0800, Tony Lindgren wrote: > > > If you have a chance, can you please provide me with some more info > > > on your system, see my recent reply to Pave

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Andrea Arcangeli <[EMAIL PROTECTED]> [050119 11:12]: > On Wed, Jan 19, 2005 at 10:19:47AM -0800, Tony Lindgren wrote: > > If you have a chance, can you please provide me with some more info > > on your system, see my recent reply to Pavel in this thread for the > > It's a normal UP athlon 1ghz,

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Andrea Arcangeli
On Wed, Jan 19, 2005 at 10:19:47AM -0800, Tony Lindgren wrote: > If you have a chance, can you please provide me with some more info > on your system, see my recent reply to Pavel in this thread for the It's a normal UP athlon 1ghz, it should be quite widespread hardware. I know at least another s

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Andrea Arcangeli <[EMAIL PROTECTED]> [050119 09:49]: > On Wed, Jan 19, 2005 at 09:13:23AM -0800, Tony Lindgren wrote: > > HZ=100 does not allow improving the idle loop much further > > from what we have. We should be able to take advantage of the > > longer idle/sleep periods inbetween the skippe

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Andrea Arcangeli
On Wed, Jan 19, 2005 at 09:13:23AM -0800, Tony Lindgren wrote: > HZ=100 does not allow improving the idle loop much further > from what we have. We should be able to take advantage of the > longer idle/sleep periods inbetween the skipped ticks. OTOH servers aren't just doing idle power saving, if

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Arjan van de Ven <[EMAIL PROTECTED]> [050119 09:31]: > On Wed, 2005-01-19 at 09:11 -0800, Tony Lindgren wrote: > > * Pavel Machek <[EMAIL PROTECTED]> [050119 03:32]: > > > Hi! > > > > > > > As this patch is related to the VST/High-Res timers, there > > > > are probably various things that can be

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Martin Schwidefsky <[EMAIL PROTECTED]> [050119 07:19]: > > > > > Stephen Frost <[EMAIL PROTECTED]> wrote on 19/01/2005 03:11:15 PM: > > > > Hrm... reading more of the patch & Martin's previous work, I'm not sure > > > I like the idea too much in the end... The main problem is that you are >

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Arjan van de Ven
On Wed, 2005-01-19 at 09:11 -0800, Tony Lindgren wrote: > * Pavel Machek <[EMAIL PROTECTED]> [050119 03:32]: > > Hi! > > > > > As this patch is related to the VST/High-Res timers, there > > > are probably various things that can be merged. I have not > > > yet looked at what all could be merged. >

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Stephen Frost <[EMAIL PROTECTED]> [050119 06:11]: > * Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: > > Hrm... reading more of the patch & Martin's previous work, I'm not sure > > I like the idea too much in the end... The main problem is that you are > > just "replaying" the ticks afterward,

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Pavel Machek <[EMAIL PROTECTED]> [050119 01:44]: > > > > > Please note that this patch alone does not help much with > > power savings. More work is needed in that area to make the > > system take advantage of the idle time inbetween the skipped > > ticks. > > Well, having HZ=100 instead of HZ=

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Tony Lindgren
* Pavel Machek <[EMAIL PROTECTED]> [050119 03:32]: > Hi! > > > As this patch is related to the VST/High-Res timers, there > > are probably various things that can be merged. I have not > > yet looked at what all could be merged. > > > > I'd appreciate some comments and testing! > > Good news is

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Stephen Frost
* Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: > Hrm... reading more of the patch & Martin's previous work, I'm not sure > I like the idea too much in the end... The main problem is that you are > just "replaying" the ticks afterward, which I see as a problem for > things like sched_clock() wh

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > As this patch is related to the VST/High-Res timers, there > are probably various things that can be merged. I have not > yet looked at what all could be merged. > > I'd appreciate some comments and testing! Good news is that it does seem to reduce number of interrupts. Bad news is that ti

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > > No, that's fine, we already have to call it before entering the PM > > state, so I'll just pass it along and, at the low level, decide how > > deep to sleep based on that. > > > > I think I should also add some stats on the amount of interrupts, since > > it would be fairly inefficient to

Re: [PATCH] dynamic tick patch

2005-01-19 Thread Pavel Machek
Hi! > Attached is the dynamic tick patch for x86 to play with > as I promised in few threads earlier on this list.[1][2] > > The dynamic tick patch does following: > > - Separates timer interrupts from updating system time > > - Allows updating time from other interrupts in addition > to time

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
* Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 23:09]: > On Tue, 2005-01-18 at 22:37 -0800, Tony Lindgren wrote: > > * Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 21:29]: > > > Hrm... reading more of the patch & Martin's previous work, I'm not sure > > > I like the idea too much in the

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Benjamin Herrenschmidt
On Tue, 2005-01-18 at 22:37 -0800, Tony Lindgren wrote: > * Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 21:29]: > > Hrm... reading more of the patch & Martin's previous work, I'm not sure > > I like the idea too much in the end... The main problem is that you are > > just "replaying" the tic

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
* Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 21:29]: > Hrm... reading more of the patch & Martin's previous work, I'm not sure > I like the idea too much in the end... The main problem is that you are > just "replaying" the ticks afterward, which I see as a problem for > things like sched_c

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
* Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 21:45]: > On Tue, 2005-01-18 at 21:21 -0800, Tony Lindgren wrote: > > * Tony Lindgren <[EMAIL PROTECTED]> [050118 21:08]: > > > * Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 20:22]: > > > > > > > > BTW. Is it possible, when entering the "i

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Benjamin Herrenschmidt
On Tue, 2005-01-18 at 21:21 -0800, Tony Lindgren wrote: > * Tony Lindgren <[EMAIL PROTECTED]> [050118 21:08]: > > * Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 20:22]: > > > > > > BTW. Is it possible, when entering the "idle" loop, to quickly know an > > > estimate of when the next tick shou

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Benjamin Herrenschmidt
Hrm... reading more of the patch & Martin's previous work, I'm not sure I like the idea too much in the end... The main problem is that you are just "replaying" the ticks afterward, which I see as a problem for things like sched_clock() which returns the real current time, no ? I'll toy a bit with

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
* Tony Lindgren <[EMAIL PROTECTED]> [050118 21:08]: > * Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 20:22]: > > > > BTW. Is it possible, when entering the "idle" loop, to quickly know an > > estimate of when the next tick shoud actually kick in ? > > Yes, see next_timer_interrupt() for that

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
* Benjamin Herrenschmidt <[EMAIL PROTECTED]> [050118 20:22]: > On Tue, 2005-01-18 at 16:05 -0800, Tony Lindgren wrote: > > Hi all, > > > > Attached is the dynamic tick patch for x86 to play with > > as I promised in few threads earlier on this list.[1][2] > > > > The dynamic tick patch does follo

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Benjamin Herrenschmidt
On Tue, 2005-01-18 at 16:05 -0800, Tony Lindgren wrote: > Hi all, > > Attached is the dynamic tick patch for x86 to play with > as I promised in few threads earlier on this list.[1][2] > > The dynamic tick patch does following: > > .../... Nice, that's exactly what I want on ppc to allow the lap

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
* Lee Revell <[EMAIL PROTECTED]> [050118 16:22]: > On Tue, 2005-01-18 at 16:05 -0800, Tony Lindgren wrote: > > Currently supported timers are TSC and ACPI PM timer. Other > > timers should be easy to add. Both TSC and ACPI PM timer > > rely on the PIT timer for interrupts, so the maximum skip > > i

Re: [PATCH] dynamic tick patch

2005-01-18 Thread Lee Revell
On Tue, 2005-01-18 at 16:05 -0800, Tony Lindgren wrote: > Currently supported timers are TSC and ACPI PM timer. Other > timers should be easy to add. Both TSC and ACPI PM timer > rely on the PIT timer for interrupts, so the maximum skip > inbetween ticks is only few seconds at most. > An interest

[PATCH] dynamic tick patch

2005-01-18 Thread Tony Lindgren
Hi all, Attached is the dynamic tick patch for x86 to play with as I promised in few threads earlier on this list.[1][2] The dynamic tick patch does following: - Separates timer interrupts from updating system time - Allows updating time from other interrupts in addition to timer interrupt -