Re: [PATCH] drop unneeded variable in amd_apic_timer_broken

2007-08-08 Thread Tim Gardner
Cal Peake wrote: > On Wed, 8 Aug 2007, Andi Kleen wrote: > >> Can you please test if this patch works? > > Yep, seems to do the trick. Thanks! > >> BTW I checked with AMD and they seem to think it's just a buggy BIOS. > > Nod. Atleast we can work around it. > >> Use global flag to disable brok

Re: [PATCH] drop unneeded variable in amd_apic_timer_broken

2007-08-08 Thread Cal Peake
On Wed, 8 Aug 2007, Andi Kleen wrote: > Can you please test if this patch works? Yep, seems to do the trick. Thanks! > BTW I checked with AMD and they seem to think it's just a buggy BIOS. Nod. Atleast we can work around it. > Use global flag to disable broken local apic timer on AMD CPUs. >

Re: [PATCH] drop unneeded variable in amd_apic_timer_broken

2007-08-08 Thread Andi Kleen
On Wednesday 08 August 2007 02:53:21 Cal Peake wrote: > On Wed, 8 Aug 2007, Andi Kleen wrote: > > > Not sure why the MSR varies between cores though. > > Yeah that boggled me too. > > > It's better to just make it a global instead. > > Haven't gotten to figuring out how to do *that* yet... but

[PATCH] drop unneeded variable in amd_apic_timer_broken

2007-08-07 Thread Cal Peake
On Wed, 8 Aug 2007, Andi Kleen wrote: > Not sure why the MSR varies between cores though. Yeah that boggled me too. > It's better to just make it a global instead. Haven't gotten to figuring out how to do *that* yet... but here's a cleanup for the detection function: From: Cal Peake <[EMAIL P