Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-16 Thread Guoqing Jiang
Hi David, David Teigland wrote: > On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: > >> Do you consider take the following clean up? If yes, I will send a >> formal patch, otherwise pls ignore it. >> > > On first glance, the old and new code do not appear to do the same thing

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-11 Thread David Teigland
On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: > Do you consider take the following clean up? If yes, I will send a > formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. > - to_nodeid =

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-11 Thread Guoqing Jiang
Hi David, David Teigland wrote: > On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: > >> The remove_from_waiters could only be invoked after failed to >> create_message, right? >> Since send_message always returns 0, this patch doesn't touch anything >> about the failure >> path,

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread Guoqing Jiang
Bob Peterson wrote: > > - Original Message - > > > >> We don't need the redundant logic since send_message always returns 0. >> >> Signed-off-by: Guoqing Jiang >> --- >> fs/dlm/lock.c | 10 ++ >>

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: > The remove_from_waiters could only be invoked after failed to > create_message, right? > Since send_message always returns 0, this patch doesn't touch anything > about the failure > path, and it also doesn't change the original seman

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread Bob Peterson
- Original Message - > Bob Peterson wrote: > > - Original Message - > > > >> Hi Bob, > >> > >> Bob Peterson wrote: > >> > >>> - Original Message - > >>> > >>> > We don't need the redundant logic since send_message always returns 0. > > Signed

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Guoqing Jiang
Bob Peterson wrote: > - Original Message - > >> Hi Bob, >> >> Bob Peterson wrote: >> >>> - Original Message - >>> >>> We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang --- fs/dlm/lock.c |

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Bob Peterson
- Original Message - > Hi Bob, > > Bob Peterson wrote: > > - Original Message - > > > >> We don't need the redundant logic since send_message always returns 0. > >> > >> Signed-off-by: Guoqing Jiang > >> --- > >> fs/dlm/lock.c | 10 ++ > >> 1 file changed, 2 insertions

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Guoqing Jiang
Hi Bob, Bob Peterson wrote: > - Original Message - > >> We don't need the redundant logic since send_message always returns 0. >> >> Signed-off-by: Guoqing Jiang >> --- >> fs/dlm/lock.c | 10 ++ >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/fs/dlm/lock.

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Bob Peterson
- Original Message - > We don't need the redundant logic since send_message always returns 0. > > Signed-off-by: Guoqing Jiang > --- > fs/dlm/lock.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c > index 35502d4..6fc3de9

[PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Guoqing Jiang
We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang --- fs/dlm/lock.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 35502d4..6fc3de9 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c