[PATCH] compat ioctl security hook fixup (take2)

2005-01-20 Thread Chris Wright
* Andi Kleen ([EMAIL PROTECTED]) wrote: > On Thu, Jan 20, 2005 at 09:51:03PM -0800, Chris Wright wrote: > > > If you add it make at least sure it's not EXPORT_SYMBOL()ed. > > > > It's certainly not, nor intended to be. Would a comment to that > > affect alleviate your concern? > > Yes please. P

Re: [PATCH] compat ioctl security hook fixup

2005-01-20 Thread Andi Kleen
On Thu, Jan 20, 2005 at 09:51:03PM -0800, Chris Wright wrote: > > If you add it make at least sure it's not EXPORT_SYMBOL()ed. > > It's certainly not, nor intended to be. Would a comment to that > affect alleviate your concern? Yes please. -Andi - To unsubscribe from this list: send the line "u

Re: [PATCH] compat ioctl security hook fixup

2005-01-20 Thread Chris Wright
* Andi Kleen ([EMAIL PROTECTED]) wrote: > I'm not sure really adding vfs_ioctl is a good idea politically. > I predict we'll see drivers starting to use it, which will cause quite > broken design. Yes, that'd be quite broken. I didn't have the same expectation. > If you add it make at least sure

Re: [PATCH] compat ioctl security hook fixup

2005-01-20 Thread Andi Kleen
On Thu, Jan 20, 2005 at 05:26:56PM -0800, Chris Wright wrote: > * Michael S. Tsirkin ([EMAIL PROTECTED]) wrote: > > Security hook seems to be missing before compat_ioctl in mm2. > > And, it would be nice to avoid calling it twice on some paths. > > > > Chris Wright's patch addressed this in the mo

[PATCH] compat ioctl security hook fixup

2005-01-20 Thread Chris Wright
* Michael S. Tsirkin ([EMAIL PROTECTED]) wrote: > Security hook seems to be missing before compat_ioctl in mm2. > And, it would be nice to avoid calling it twice on some paths. > > Chris Wright's patch addressed this in the most elegant way I think, > by adding vfs_ioctl. The patch below is again