On Thu, Jan 20, 2005 at 05:26:56PM -0800, Chris Wright wrote: > * Michael S. Tsirkin ([EMAIL PROTECTED]) wrote: > > Security hook seems to be missing before compat_ioctl in mm2. > > And, it would be nice to avoid calling it twice on some paths. > > > > Chris Wright's patch addressed this in the most elegant way I think, > > by adding vfs_ioctl. > > The patch below is against Linus' tree as per Andrew's request. It will > conflict with some of the changes in -mm2 (including the some-fixes bit > from Andi, and LTT). I also have a patch directly against -mm2 if anyone > would like to see that instead.
I'm not sure really adding vfs_ioctl is a good idea politically. I predict we'll see drivers starting to use it, which will cause quite broken design. If you add it make at least sure it's not EXPORT_SYMBOL()ed. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
