Re: [PATCH] UBI: Don't use signed int as array index before testing if it is negative

On Sat, 2007-08-04 at 01:25 +0200, Jesper Juhl wrote: > Hi, > > I can't find anything guaranteeing that 'ubi_num' cannot be <0 in > drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code > even tests for that and errors out if so. Unfortunately the test > for "ubi_num < 0" happens afte

[PATCH] UBI: Don't use signed int as array index before testing if it is negative

Hi, I can't find anything guaranteeing that 'ubi_num' cannot be <0 in drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code even tests for that and errors out if so. Unfortunately the test for "ubi_num < 0" happens after we've already used 'ubi_num' as an array index - bad thing to d