On Sat, 2007-08-04 at 01:25 +0200, Jesper Juhl wrote: > Hi, > > I can't find anything guaranteeing that 'ubi_num' cannot be <0 in > drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code > even tests for that and errors out if so. Unfortunately the test > for "ubi_num < 0" happens after we've already used 'ubi_num' as > an array index - bad thing to do if it is negative. > This patch moves the test earlier in the function and then moves > the indexing using that variable after the check. A bit safer :-) > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Thanks for the catch, committed to UBI git tree. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
