Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-04 Thread Daniel Thompson
On Tue, Nov 03, 2020 at 09:36:54PM +0100, Tabot Kevin wrote: > On Tue, Nov 03, 2020 at 10:04:40AM +, Daniel Thompson wrote: > > On Mon, Nov 02, 2020 at 01:15:56PM +0100, Tabot Kevin wrote: > > > On Mon, Nov 02, 2020 at 09:33:24AM +, Daniel Thompson wrote: > > > > > @@ -146,7 +146,7 @@ stati

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-03 Thread Tabot Kevin
On Tue, Nov 03, 2020 at 10:04:40AM +, Daniel Thompson wrote: > On Mon, Nov 02, 2020 at 01:15:56PM +0100, Tabot Kevin wrote: > > On Mon, Nov 02, 2020 at 09:33:24AM +, Daniel Thompson wrote: > > > On Sat, Oct 31, 2020 at 05:41:03PM +0100, Tabot Kevin wrote: > > > > This patch fixes the follow

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-03 Thread Daniel Thompson
On Mon, Nov 02, 2020 at 01:15:56PM +0100, Tabot Kevin wrote: > On Mon, Nov 02, 2020 at 09:33:24AM +, Daniel Thompson wrote: > > On Sat, Oct 31, 2020 at 05:41:03PM +0100, Tabot Kevin wrote: > > > This patch fixes the following: > > > - Uses __func__ macro to print function names. > > > - Got rid

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-02 Thread Tabot Kevin
Greetings Daniel, Thank you very much for the response. So, should I just revert back to the original all the changes in places where I replace hard coded functions names with   __func__? Kind regards, Tabot Kevin. On Mon, Nov 02, 2020 at 09:33:24AM +, Daniel Thompson wrote: > On Sat, Oc

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-02 Thread Daniel Thompson
On Sat, Oct 31, 2020 at 05:41:03PM +0100, Tabot Kevin wrote: > This patch fixes the following: > - Uses __func__ macro to print function names. > - Got rid of unnecessary braces around single line if statements. > - End of block comments on a seperate line. > - A spelling mistake of the word "on".

[PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-10-31 Thread Tabot Kevin
This patch fixes the following: - Uses __func__ macro to print function names. - Got rid of unnecessary braces around single line if statements. - End of block comments on a seperate line. - A spelling mistake of the word "on". Signed-off-by: Tabot Kevin --- drivers/staging/media/atomisp/i2c/ato