Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-28 Thread matthieu castet
Hi, Shaohua Li wrote: On Wed, 2005-08-03 at 23:16 +0200, matthieu castet wrote: There are drivers/acpi/motherboard.c that done some stuff already handle by pnp/system.c. Yes, it should be disabled if pnpacpi is enabled. But even if pnpacpi is disabled, pnp/system.c sould work with pnpbios.

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-04 Thread matthieu castet
Bjorn Helgaas wrote: On Thursday 04 August 2005 6:38 am, matthieu castet wrote: Bjorn Helgaas wrote: On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: Bjorn Helgaas wrote: drivers/char/hpet.c This probably should be converted to PNP. I'll

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-04 Thread Bjorn Helgaas
On Thursday 04 August 2005 6:38 am, matthieu castet wrote: > Bjorn Helgaas wrote: > > On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: > >>Bjorn Helgaas wrote: > >> > drivers/char/hpet.c > >> > This probably should be converted to PNP. I'll > >> > look into doing this

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-04 Thread matthieu castet
Hi, Bjorn Helgaas wrote: On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: Bjorn Helgaas wrote: >drivers/char/hpet.c >This probably should be converted to PNP. I'll >look into doing this. IIRC, I am not sure that the pnp layer was able to pass the 64 bits

Re: [ACPI] [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Kenji Kaneshige
Hi Bjorn, Thank you very much for the new patch and I'm very sorry for troubling you. The patch looks very good to me. Thanks, Kenji Kaneshige Bjorn Helgaas wrote: On Tuesday 02 August 2005 7:05 pm, Kenji Kaneshige wrote: This breaks the following patch that is already included into -mm tr

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Shaohua Li
On Wed, 2005-08-03 at 23:16 +0200, matthieu castet wrote: > > There are drivers/acpi/motherboard.c that done some stuff already handle > by pnp/system.c. Yes, it should be disabled if pnpacpi is enabled. The only concern is motherboard.c also request some ACPI resources, which might not declaim i

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Shaohua Li
On Wed, 2005-08-03 at 09:20 -0600, Bjorn Helgaas wrote: > On Tuesday 02 August 2005 7:01 pm, Shaohua Li wrote: > > On Tue, 2005-08-02 at 09:55 -0600, Bjorn Helgaas wrote: > > > Any objections to the patch below? I posted it last Wednesday, > > > but haven't heard anything. Once we have this fix,

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Bjorn Helgaas
On Wednesday 03 August 2005 3:16 pm, matthieu castet wrote: > Bjorn Helgaas wrote: > > On Tuesday 02 August 2005 7:01 pm, Shaohua Li wrote: > >>Did you have plan to remove other > >>legacy acpi drivers? > > No, I didn't -- which ones are you thinking about? Looking at > > the callers of acpi_

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread matthieu castet
Hi, Bjorn Helgaas wrote: > On Tuesday 02 August 2005 7:01 pm, Shaohua Li wrote: > > >>Did you have plan to remove other >>legacy acpi drivers? > > > No, I didn't -- which ones are you thinking about? Looking at > the callers of acpi_bus_register_driver(), I see: looking for METHOD_NAME__CRS is

Re: [ACPI] [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Bjorn Helgaas
On Tuesday 02 August 2005 7:05 pm, Kenji Kaneshige wrote: > This breaks the following patch that is already included into -mm > tree. > > http://sourceforge.net/mailarchive/forum.php?thread_id=7844247&forum_id=6102 > > I think we need to check if acpi_register_gsi() succeeded or not. You're abso

Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Bjorn Helgaas
On Tuesday 02 August 2005 7:01 pm, Shaohua Li wrote: > On Tue, 2005-08-02 at 09:55 -0600, Bjorn Helgaas wrote: > > Any objections to the patch below? I posted it last Wednesday, > > but haven't heard anything. Once we have this fix, 8250_pnp > > should have sufficient functionality that we can ge

Re: [ACPI] [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-02 Thread Kenji Kaneshige
Hi Bjorn, static void -pnpacpi_parse_allocated_irqresource(struct pnp_resource_table * res, int irq) +pnpacpi_parse_allocated_irqresource(struct pnp_resource_table * res, u32 irq) { int i = 0; while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) && @@ -85,13 +85,13 @@

Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-02 Thread Shaohua Li
On Tue, 2005-08-02 at 09:55 -0600, Bjorn Helgaas wrote: > Any objections to the patch below? I posted it last Wednesday, > but haven't heard anything. Once we have this fix, 8250_pnp > should have sufficient functionality that we can get rid of > 8250_acpi. > > > > Use types that match the ACP

[PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-02 Thread Bjorn Helgaas
Any objections to the patch below? I posted it last Wednesday, but haven't heard anything. Once we have this fix, 8250_pnp should have sufficient functionality that we can get rid of 8250_acpi. Use types that match the ACPI resource structures. Previously the u64 value from an RSTYPE_ADDRESS6