Re: [PATCH] PCI legacy resource fix

2006-12-09 Thread Ben Collins
On Sat, 2006-12-09 at 13:14 +, Alan wrote: > On Sat, 09 Dec 2006 03:12:11 -0500 > Ben Collins <[EMAIL PROTECTED]> wrote: > > My controller is in legacy mode, however, it never gets to here because > > of this call, just before this block of code: > > > > rc = pci_request_regions(pdev,

Re: [PATCH] PCI legacy resource fix

2006-12-09 Thread Alan
On Sat, 09 Dec 2006 03:12:11 -0500 Ben Collins <[EMAIL PROTECTED]> wrote: And NAK the patch because its about 500 times longer than the real fix that was posted. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] PCI legacy resource fix

2006-12-09 Thread Alan
On Sat, 09 Dec 2006 03:12:11 -0500 Ben Collins <[EMAIL PROTECTED]> wrote: > My controller is in legacy mode, however, it never gets to here because > of this call, just before this block of code: > > rc = pci_request_regions(pdev, DRV_NAME); > if (rc) { > disable_de

Re: [PATCH] PCI legacy resource fix

2006-12-09 Thread Ben Collins
On Sat, 2006-12-09 at 02:46 +, Alan wrote: > > Checking the patch, my problem is that the old way, all BAR's were being > > set at start = end = flags = 0. The patch makes it set all the BAR's to > > Yes the old quirk used to blank the resources as the values on the chip > are undefined and ra

Re: [PATCH] PCI legacy resource fix

2006-12-08 Thread Alan
> Checking the patch, my problem is that the old way, all BAR's were being > set at start = end = flags = 0. The patch makes it set all the BAR's to Yes the old quirk used to blank the resources as the values on the chip are undefined and random. This gives you corrupt resource trees and needs hac

Re: [PATCH] PCI legacy resource fix

2006-12-08 Thread Ben Collins
On Sat, 2006-12-09 at 01:25 +, Ralf Baechle wrote: > On Fri, Dec 08, 2006 at 07:46:18PM -0500, Ben Collins wrote: > > > On Wed, 2006-12-06 at 13:41 +, Ralf Baechle wrote: > > > Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try > > > to update the non-writeable BAR r

Re: [PATCH] PCI legacy resource fix

2006-12-08 Thread Ralf Baechle
On Fri, Dec 08, 2006 at 07:46:18PM -0500, Ben Collins wrote: > On Wed, 2006-12-06 at 13:41 +, Ralf Baechle wrote: > > Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try > > to update the non-writeable BAR registers 0..3 of PIIX4 IDE adapters if > > pci_assign_unassigned_

Re: [PATCH] PCI legacy resource fix

2006-12-08 Thread Ben Collins
On Wed, 2006-12-06 at 13:41 +, Ralf Baechle wrote: > Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try > to update the non-writeable BAR registers 0..3 of PIIX4 IDE adapters if > pci_assign_unassigned_resources() is used to do full resource assignment > of the bus. This

Re: [PATCH] PCI legacy resource fix

2006-12-06 Thread Alan
On Wed, 6 Dec 2006 13:41:43 + Ralf Baechle <[EMAIL PROTECTED]> wrote: > Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try > to update the non-writeable BAR registers 0..3 of PIIX4 IDE adapters if > pci_assign_unassigned_resources() is used to do full resource assignment

[PATCH] PCI legacy resource fix

2006-12-06 Thread Ralf Baechle
Since commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f the kernel will try to update the non-writeable BAR registers 0..3 of PIIX4 IDE adapters if pci_assign_unassigned_resources() is used to do full resource assignment of the bus. This fails because in the PIIX4 these BAR registers have implicitly