Re: [Linux-kernel-mentees] [PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-10 Thread Kelsey Skunberg
On Sat, Aug 10, 2019 at 07:24:09PM +0200, Greg KH wrote: > On Sat, Aug 10, 2019 at 12:15:25PM -0500, Bjorn Helgaas wrote: > > On Sat, Aug 10, 2019 at 09:17:19AM +0200, Greg KH wrote: > > > On Fri, Aug 09, 2019 at 01:57:21PM -0600, Kelsey Skunberg wrote: > > > > +static struct device_attribute sriov

Re: [Linux-kernel-mentees] [PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-10 Thread Greg KH
On Sat, Aug 10, 2019 at 12:15:25PM -0500, Bjorn Helgaas wrote: > On Sat, Aug 10, 2019 at 09:17:19AM +0200, Greg KH wrote: > > On Fri, Aug 09, 2019 at 01:57:21PM -0600, Kelsey Skunberg wrote: > > > +static struct device_attribute sriov_totalvfs_attr = > > > __ATTR_RO(sriov_totalvfs); > > > > DEVIC

Re: [Linux-kernel-mentees] [PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-10 Thread Bjorn Helgaas
On Sat, Aug 10, 2019 at 09:17:19AM +0200, Greg KH wrote: > On Fri, Aug 09, 2019 at 01:57:21PM -0600, Kelsey Skunberg wrote: > > +static struct device_attribute sriov_totalvfs_attr = > > __ATTR_RO(sriov_totalvfs); > > DEVICE_ATTR_RO() please. This is a device attribute, not a "raw" > kobject attr

Re: [Linux-kernel-mentees] [PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-10 Thread Greg KH
On Fri, Aug 09, 2019 at 01:57:21PM -0600, Kelsey Skunberg wrote: > +static struct device_attribute sriov_totalvfs_attr = > __ATTR_RO(sriov_totalvfs); DEVICE_ATTR_RO() please. This is a device attribute, not a "raw" kobject attribute. > +static struct device_attribute sriov_numvfs_attr = > +

[PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-09 Thread Kelsey Skunberg
The sysfs SR-IOV functions are for an optional feature and will be better organized to keep with the feature's code. Move the sysfs SR-IOV functions to /pci/iov.c. Signed-off-by: Kelsey Skunberg --- drivers/pci/iov.c | 173 +++ drivers/pci/pci-sysfs.c |