On Fri, Aug 09, 2019 at 01:57:21PM -0600, Kelsey Skunberg wrote: > +static struct device_attribute sriov_totalvfs_attr = > __ATTR_RO(sriov_totalvfs);
DEVICE_ATTR_RO() please. This is a device attribute, not a "raw" kobject attribute. > +static struct device_attribute sriov_numvfs_attr = > + __ATTR(sriov_numvfs, (S_IRUGO | S_IWUSR | S_IWGRP), > + sriov_numvfs_show, sriov_numvfs_store); > +static struct device_attribute sriov_offset_attr = __ATTR_RO(sriov_offset); > +static struct device_attribute sriov_stride_attr = __ATTR_RO(sriov_stride); > +static struct device_attribute sriov_vf_device_attr = > + __ATTR_RO(sriov_vf_device); > +static struct device_attribute sriov_drivers_autoprobe_attr = > + __ATTR(sriov_drivers_autoprobe, (S_IRUGO | S_IWUSR | S_IWGRP), > + sriov_drivers_autoprobe_show, > + sriov_drivers_autoprobe_store); Same for all of these, they should use DEVICE_ATTR* macros. And why the odd permissions on 2 of these files? Are you sure about that? thanks, greg k-h
