Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-11 Thread H. Peter Anvin
Greg KH wrote: On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote: + if (hdr->id == id_nic) { + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, + (nic->pci_bdf & 0xff)); pci_get_bus_and_slot fails in the

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-11 Thread Greg KH
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote: > > > + if (hdr->id == id_nic) { > > > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> > > > 8, + (nic->pci_bdf & 0xff)); > > pci_get_bus_and_slot fails in

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-11 Thread Konrad Rzeszutek
> > + if (hdr->id == id_nic) { > > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> > > 8, + (nic->pci_bdf & 0xff)); > pci_get_bus_and_slot fails in the presence of PCI domains, which are > getting to be fairly common even

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > + if (hdr->id == id_nic) { > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, > + (nic->pci_bdf & 0xff)); > + if (pci_dev) { > +

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > + ibft_device = kmalloc(len, GFP_KERNEL); > + if (!ibft_device) > + return -ENOMEM; > + > + memcpy(ibft_device, hdr, len); This piece looks a bit odd. you're making ibft_device an exact duplicate of ibft_

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > +/* > + * Physical location of iSCSI Boot Format Table. This is now the Virtual address, isn't it? So just drop the Physical. > + */ > +unsigned long ibft_addr; > +EXPORT_SYMBOL(ibft_addr); And since it is the virtual address, there's

REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread Konrad Rzeszutek
Whoops. I've attached an incorrect patch in the previous e-mail (http://lkml.org/lkml/2008/2/8/350) that didn't take in to account the 'reserve_bootmem' parameters changes. Here is fresher copy which has been tested on 2.6.24-git19 on a machine with iBFT and without. This patch (v0.4.7) adds /sys

Re: [PATCH] Add iSCSI iBFT support (v0.4.6)

2008-02-08 Thread Konrad Rzeszutek
On Friday 01 February 2008 19:18:09 James Bottomley wrote: > On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote: > > This patch (v0.4.6) adds > Some pieces of the patch are obviously wrong: find_ibft() shouldn't be > in ibft_init ... if ibft_phys was zero, it means the bootmem reservation

[PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread Konrad Rzeszutek
This patch (v0.4.7) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI co

Re: [PATCH] Add iSCSI iBFT support (v0.4.6)

2008-02-01 Thread Andrew Morton
On Fri, 01 Feb 2008 18:18:09 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > Also, move the reserve_bootmem into the ibft_find routines and ensure > they're only called once on boot. And note that the reserve_bootmem() interface is about to change. http://userweb.kernel.org/~akpm/mmotm/broken

Re: [PATCH] Add iSCSI iBFT support (v0.4.6)

2008-02-01 Thread James Bottomley
On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote: > This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > directories along with text properties which export the the iSCSI > Boot Firmware Table (iBFT) structure. > > What is iSCSI Boot Firmware Table? It is a mechan

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-30 Thread Konrad Rzeszutek
> That being said, I don't think there's any reason to expect the table to > show up on anything but i386 and x86_64, and maybe ia64. I've posted a new patch (http://lkml.org/lkml/2008/1/30/531) that includes that dependency in the Kconfig (i386, x86_64, ia64) -- To unsubscribe from this list

[PATCH] Add iSCSI iBFT support (v0.4.6)

2008-01-30 Thread Konrad Rzeszutek
This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI c

Re: [PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header files.

2008-01-29 Thread Konrad Rzeszutek
On Tuesday 29 January 2008 14:15:15 Mike Christie wrote: > Konrad Rzeszutek wrote: > > +/* > > + * Helper functions to parse data properly. > > + */ > > +static ssize_t sprintf_ipaddr(char *buf, u8 *ip) > > +{ > > + if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 && > > + ip[4] ==

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-29 Thread Greg KH
On Tue, Jan 29, 2008 at 01:13:28PM -0600, Mike Christie wrote: > Konrad Rzeszutek wrote: >> On Sunday 27 January 2008 01:01:23 you wrote: On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote: Hey Andrew, Please add this patch along with Greg KH's kobject

Re: [PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header files.

2008-01-29 Thread Mike Christie
Konrad Rzeszutek wrote: +/* + * Helper functions to parse data properly. + */ +static ssize_t sprintf_ipaddr(char *buf, u8 *ip) +{ + if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 && + ip[4] == 0 && ip[5] == 0 && ip[6] == 0 && ip[7] == 0 && + ip[8] == 0 && ip[9

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-29 Thread Mike Christie
Konrad Rzeszutek wrote: On Sunday 27 January 2008 01:01:23 you wrote: On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote: Hey Andrew, Please add this patch along with Greg KH's kobject fixes. erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Peter Jones
Konrad Rzeszutek wrote: iBFT is not platform-independent; it only makes sense on platforms with ACPI (and even then, just barely; ACPI is a poor fit for it and it was probably "integrated" with ACPI for political reasons.) The spec just mentions that iBFT table has to be "compatible with an ACP

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Konrad Rzeszutek
> iBFT is not platform-independent; it only makes sense on platforms with > ACPI (and even then, just barely; ACPI is a poor fit for it and it was > probably "integrated" with ACPI for political reasons.) The spec just mentions that iBFT table has to be "compatible with an ACPI table format" and

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread H. Peter Anvin
Doug Maxey wrote: On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote: +EXPORT_SYMBOL(find_ibft); Is this x86-specific? Are suitable Kconfig dependencies in place? Originally I had it to be x86-specific but was told that I should make it all platforms since the IBFT is platform independe

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Doug Maxey
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote: > > > +EXPORT_SYMBOL(find_ibft); > > > > Is this x86-specific? Are suitable Kconfig dependencies in place? > > Originally I had it to be x86-specific but was told that I should make it all > platforms since the IBFT is platform independe

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Konrad Rzeszutek
On Sunday 27 January 2008 01:01:23 you wrote: > > On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> > > wrote: Hey Andrew, > > > > Please add this patch along with Greg KH's kobject fixes. > > erm, OK. But I don't think I'm the appropriate conduit for iscsi paches. > > By wha

[PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header files.

2008-01-28 Thread Konrad Rzeszutek
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI co

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-28 Thread Andy Whitcroft
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote: > > int __initdata user_defined_memmap = 0; > > checkpatch should have told you that this "= 0" shouldn't be there. But it > doesn't. Ok, this line would be correctly picked up if it was being added by this author, but this line is

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-27 Thread Randy Dunlap
Andrew Morton wrote: int __initdata user_defined_memmap = 0; checkpatch should have told you that this "= 0" shouldn't be there. But it doesn't. checkpatch checks for static initializers, not non-static ones. Should that be changed? + for (pos = (u8 *)hdr; pos < (u8 *)hdr + len

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-26 Thread Andrew Morton
> On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote: > Hey Andrew, > > Please add this patch along with Greg KH's kobject fixes. erm, OK. But I don't think I'm the appropriate conduit for iscsi paches. By what path _does_ iscsi ode get into the tree, anyway? Mike is

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-26 Thread Andrew Morton
Please always include a diffstat with non-trivial patches. > On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote: > --- a/arch/x86/kernel/setup_32.c > +++ b/arch/x86/kernel/setup_32.c lol. You touched x86 code. -- To unsubscribe from this list: send the line "unsubsc

[PATCH] Add iSCSI iBFT support (v0.4.5)

2008-01-25 Thread Konrad Rzeszutek
Hey Andrew, Please add this patch along with Greg KH's kobject fixes. This module is dependent on the fixes that Greg KH has in his patches git tree. This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot

[PATCH] Add iSCSI iBFT support (v0.4.4)

2008-01-11 Thread Konrad Rzeszutek
This patch (v0.4.4) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX| extensionX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs

[PATCH] Add iSCSI IBFT support (v0.4.3)

2007-12-22 Thread Konrad Rzeszutek
This patch (v0.4.3) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX| extensionX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs

Re: [PATCH] Add iSCSI IBFT support (v0.4.3)

2007-12-21 Thread Konrad Rzeszutek
> > > > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > > > > > directories along with text properties which export the the iSCSI Boot > > > > > Firmware Table (iBFT) structure. > > > > > > > > > > What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI > > > > > t

Re: [PATCH] Add iSCSI IBFT support (v0.4.2)

2007-12-21 Thread Greg KH
On Wed, Dec 05, 2007 at 03:47:08PM -0400, Konrad Rzeszutek wrote: > On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > > Overall, looks nice. Good work. > > Thank you. > > > > > comments inline below... > > > > On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: > > > On We

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 03:02:56PM -0600, Doug Maxey wrote: > [added cc: to mikec] > > On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: > > On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > > > > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > > > Is t

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Doug Maxey
[added cc: to mikec] On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote: > On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > > Is the current include from open-iscsi being duplicated? If not, why > > > >

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote: > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > > Is the current include from open-iscsi being duplicated? If not, why > > > not consolidate in one file? > > > > The include files that come from open-iscsi that are i

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Doug Maxey
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote: > > Is the current include from open-iscsi being duplicated? If not, why > > not consolidate in one file? > > The include files that come from open-iscsi that are in the kernel do > not have the iBFT data structures in them - therefore

[PATCH] Add iSCSI IBFT support (v0.4.2)

2007-12-05 Thread Konrad Rzeszutek
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > Overall, looks nice. Good work. Thank you. > > comments inline below... > > On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: > > On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: > > > > > > This patch ad

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-05 Thread Konrad Rzeszutek
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > Overall, looks nice. Good work. Thank you. > > comments inline below... > .. snip .. > > +#include > > Is the current include from open-iscsi being duplicated? If not, why > not consolidate in one file? The include files that com

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-04 Thread Doug Maxey
Overall, looks nice. Good work. comments inline below... On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: > On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: > > > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > > directories along with text pro

Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-12-04 Thread darnok
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > directories along with text properties which export the the iSCSI Boot > Firmware Table (iBFT) structure. > > What is iSCSI Boot Firmware Table? It is a mecha

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-12-04 Thread Konrad Rzeszutek
On Thu, Nov 29, 2007 at 11:36:21AM -0400, [EMAIL PROTECTED] wrote: > > > > > > /sys/firmware/ibft/ethernet0/pci-bdf > > > 5:1:0 > > > > shouldn't this somehow also have a symlink to the kernels ethX view of > > ethernet devices? > > (and if so.. how much of the info is duplicated..) > > That NIC

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-29 Thread darnok
> > > > /sys/firmware/ibft/ethernet0/pci-bdf > > 5:1:0 > > shouldn't this somehow also have a symlink to the kernels ethX view of > ethernet devices? > (and if so.. how much of the info is duplicated..) That NIC is used by the NIC firmware (or the BIOS) to negotiate the iSCSI target. The informa

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-29 Thread Arjan van de Ven
On Mon, 26 Nov 2007 23:50:10 -0500 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote: > > > > > > sysfs files have ONE VALUE PER FILE, not a whole bunch of > > > different things in a single file. Please fix this. > > > > The subparameters _are_ actually part of a single value, that value > > being asso

[REPOST PATCH] Add iSCSI IBFT support (v0.4)

2007-11-28 Thread Konrad Rzeszutek
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI connection

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 04:24:32PM -0400, [EMAIL PROTECTED] wrote: > > But, why not just put it in a separate file, that is built in if the > > user wants iscsi support? That way the setup code can call it properly > > if needed. > > In what directory should I put that file? It can't be in the ar

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-28 Thread darnok
> > > I didn't realize an external file, outside of your changes, needed this > > > function. If it does, then perhaps you need to just place it elsewhere. > > > > The fundamental problem is that 'find_ibft' ought to be available > > from anywhere (or at least from the iscsi_ibft.c) so that the i

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 03:21:40PM -0400, [EMAIL PROTECTED] wrote: > On Tue, Nov 27, 2007 at 11:09:19AM -0800, Greg KH wrote: > > On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote: > > > On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote: > > > > On Mon, Nov 26, 2007 at 11:23:3

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-28 Thread darnok
On Tue, Nov 27, 2007 at 11:09:19AM -0800, Greg KH wrote: > On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote: > > On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote: > > > On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote: > > > > On Monday 26 November 2007 22:31

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-27 Thread Greg KH
On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote: > On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote: > > On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote: > > > On Monday 26 November 2007 22:31:38 Greg KH wrote: > > > > > +#if defined(CONFIG_ISCSI_IBFT) || d

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-27 Thread darnok
On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote: > On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote: > > On Monday 26 November 2007 22:31:38 Greg KH wrote: > > > > +#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE) > > ..snip.. > > > > +static ssize_t find_

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Greg KH
On Mon, Nov 26, 2007 at 11:50:10PM -0500, Konrad Rzeszutek wrote: > > > > > > sysfs files have ONE VALUE PER FILE, not a whole bunch of different > > > things in a single file. Please fix this. > > > > The subparameters _are_ actually part of a single value, that value being > > associated with th

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Greg KH
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote: > On Monday 26 November 2007 22:31:38 Greg KH wrote: > > > +#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE) > ..snip.. > > > +static ssize_t find_ibft(void) > > > +{ > ..snip.. > > > +} > > > > What is a function

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Doug Maxey
On Mon, 26 Nov 2007 19:31:38 PST, Greg KH wrote: > On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote: > > +/* > > + * Routines for reading of the iBFT data in a human readable fashion. > > + */ > > +ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry, > > +

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
> > > > sysfs files have ONE VALUE PER FILE, not a whole bunch of different > > things in a single file. Please fix this. > > The subparameters _are_ actually part of a single value, that value being > associated with the initiator instance. > > Konrad is trying to implement a "work-alike" for wha

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
.. snip.. > > +#else > > +static void __init reserve_ibft_region(void) { }; > > No ending ; above. Fixed. > ..snip.. > > +static void __init reserve_ibft_region(void) { }; > > Ditto. Fixed. .. snip.. > > +#include > > + > > No blank line here, please. Why that creeps back in the code I am not

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
On Monday 26 November 2007 22:31:38 Greg KH wrote: > On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote: > > +/* > > + * Routines for reading of the iBFT data in a human readable fashion. > > + */ > > +ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry, > > +

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Greg KH
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote: > +/* > + * Routines for reading of the iBFT data in a human readable fashion. > + */ > +ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry, > + struct ibft_attribute *attr, > +

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Greg KH
On Mon, Nov 26, 2007 at 06:56:42PM -0400, Konrad Rzeszutek wrote: > > This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL > PROTECTED],X|[EMAIL PROTECTED],X] > directories along with text properties which export the the iSCSI Boot > Firmware Table (iBFT) structure. The layout of the direc

Re: [PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Randy Dunlap
Konrad Rzeszutek wrote: This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL PROTECTED],X|[EMAIL PROTECTED],X] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. The layout of the directories mirrors how PowerPC OpenBoot exports this da

[PATCH] Add iSCSI IBFT Support (v0.3)

2007-11-26 Thread Konrad Rzeszutek
This patch adds /sysfs/firmware/ibft/[chosen|aliases|[EMAIL PROTECTED],X|[EMAIL PROTECTED],X] directories along with text properties which export the the iSCSI Boot Firmware Table (iBFT) structure. The layout of the directories mirrors how PowerPC OpenBoot exports this data. What is iSCSI Boot F

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread Len Brown
On Thursday 27 September 2007 13:51, Peter Jones wrote: > H. Peter Anvin wrote: > > Peter Jones wrote: > >>> It should, presumably, depend on ACPI, rather than on X86...? > >> Actually no. That /should/ be the correct answer, but none of the > >> hardware vendors actually provide the table via ACP

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread Peter Jones
H. Peter Anvin wrote: Peter Jones wrote: It should, presumably, depend on ACPI, rather than on X86...? Actually no. That /should/ be the correct answer, but none of the hardware vendors actually provide the table via ACPI yet. Also, if they did, the support for /sys/firmware/acpi/tables/* wou

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread H. Peter Anvin
Peter Jones wrote: >> >> It should, presumably, depend on ACPI, rather than on X86...? > > Actually no. That /should/ be the correct answer, but none of the > hardware vendors actually provide the table via ACPI yet. Also, if they > did, the support for /sys/firmware/acpi/tables/* would be suffi

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread Peter Jones
H. Peter Anvin wrote: Konrad Rzeszutek wrote: +config ISCSI_IBFT + tristate "iSCSI Boot Firmware Table Attributes" + depends on X86 why only on X86? PowerPC exports this data via the OpenFirmware so it already shows in the /sysfs entries. I was thinking to combine those sysfs entri

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread H. Peter Anvin
Konrad Rzeszutek wrote: >>> +config ISCSI_IBFT >>> + tristate "iSCSI Boot Firmware Table Attributes" >>> + depends on X86 >> why only on X86? > > PowerPC exports this data via the OpenFirmware so it already shows in > the /sysfs entries. I was thinking to combine those sysfs entries under thi

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 20:52:43 -0400 Konrad Rzeszutek wrote: > > > +config ISCSI_IBFT > > > + tristate "iSCSI Boot Firmware Table Attributes" > > > + depends on X86 > > > > why only on X86? > > PowerPC exports this data via the OpenFirmware so it already shows in > the /sysfs entries. I was thinki

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Randy Dunlap
Ram Dorai wrote: Fixed. > > +static int > > +ibft_mmap_binary(struct kobject *kobj, struct bin_attribute *attr, > > +struct vm_area_struct *vma) > Do we not put a space between binary and '('. Is that against the coding guidelines? Right, we do not p

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Greg KH
On Wed, Sep 26, 2007 at 08:08:45PM -0400, Konrad Rzeszutek wrote: > On Wednesday 26 September 2007 17:10:57 Greg KH wrote: > > On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote: > > > This patch adds a /sysfs/firmware/ibft/table binary blob which exports > > > the iSCSI Boot Firmware

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
> > +config ISCSI_IBFT > > + tristate "iSCSI Boot Firmware Table Attributes" > > + depends on X86 > > why only on X86? PowerPC exports this data via the OpenFirmware so it already shows in the /sysfs entries. I was thinking to combine those sysfs entries under this code, but that is somethin

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
On Wednesday 26 September 2007 17:10:57 Greg KH wrote: > On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote: > > This patch adds a /sysfs/firmware/ibft/table binary blob which exports > > the iSCSI Boot Firmware Table (iBFT) structure. > > Please don't do that. Binary files are for t

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
> > i.e., what is this binary blob (?) > > I don't see a binary blob in this patch (as stated in the first > sentence). I'd say that this patch adds methods for exporting > (or exposing) the ibft thru sysfs. I used the wrong choice of words. The correct one is, as you say, to add methods for exp

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 14:46:52 -0400 Konrad Rzeszutek wrote: > This patch adds a /sysfs/firmware/ibft/table binary blob which exports > the iSCSI Boot Firmware Table (iBFT) structure. > > What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI > tools to extract from the machine NICs th

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 14:46:52 -0400 Konrad Rzeszutek wrote: > This patch adds a /sysfs/firmware/ibft/table binary blob which exports > the iSCSI Boot Firmware Table (iBFT) structure. > > What is iSCSI Boot Firmware Table? i.e., what is this binary blob (?) I don't see a binary blob in this pat

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Greg KH
On Wed, Sep 26, 2007 at 02:46:52PM -0400, Konrad Rzeszutek wrote: > This patch adds a /sysfs/firmware/ibft/table binary blob which exports > the iSCSI Boot Firmware Table (iBFT) structure. Please don't do that. Binary files are for things that are "pass-through" only, not anything that the kerne

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread roel
Konrad Rzeszutek wrote: [...] > +static ssize_t > +ibft_read_binary(struct kobject *kobj, struct bin_attribute *attr, char *buf, > + loff_t off, size_t count) > +{ > + > + struct ibft_device *ibft = container_of(kobj, struct ibft_device, kobj); > + ssize_t len = ibft->hdr->le

[PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
This patch adds a /sysfs/firmware/ibft/table binary blob which exports the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI connection information so that they can automagically mount th