On Wed, Dec 05, 2007 at 03:47:08PM -0400, Konrad Rzeszutek wrote: > On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote: > > Overall, looks nice. Good work. > > Thank you. > > > > > comments inline below... > > > > On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote: > > > On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote: > > > > > > > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX] > > > > directories along with text properties which export the the iSCSI Boot > > > > Firmware Table (iBFT) structure. > > > > > > > > What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI > > > > tools to extract from the machine NICs the iSCSI connection information > > > > so that they can automagically mount the iSCSI share/target. Currently > > > > the iSCSI information is hard-coded in the initrd. > > > > > > > > For full details of the IBFT structure please take a look at: > > > > ftp://ftp.software.ibm.com/systems/support/system_x_pdf/ibm_iscsi_boot_firmware_table_v1.02.pdf > > > > > > Here is an updated version which provides an attribute symlink (in the > > > ethernetX directory) called 'device' to the NIC device, instead of > > > exporting a 'pci_bdf' file which had the "bus:slot:func" values. > > > > > > Review would be much appreciated. > > This next version (0.4.2) includes: much better error unrolling > when kobject registration fails, fixes from Doug's review, and uses the > 'kset_create_and_add' API that Greg KH posted. It has been tested on > todays 2.6.24-rc4-gkh tree.
Looks much nicer, good job. However I changed the kobject api again, so some minor changes will need to happen (kobject_init() and kobject_add() parameters have changed), and you don't need to call kobject_del() right before kobject_put(). Hm, that last one was always true, so that wasn't needed before... Do you want me to add this to my driver/ tree and fix up the kobject issues there so it all builds properly, and it gets sent to Linus for 2.6.25? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
