Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-03-16 Thread Mark Brown
On Thu, Mar 12, 2015 at 10:17:11AM +0800, Songjun Wu wrote: > Enable WM8731 to support common clock framework. Applied, thanks. signature.asc Description: Digital signature

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-03-16 Thread Charles Keepax
On Thu, Mar 12, 2015 at 10:17:11AM +0800, Songjun Wu wrote: > Enable WM8731 to support common clock framework. > > Signed-off-by: Songjun Wu > --- Looks ok to me: Acked-by: Charles Keepax Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-03-11 Thread Songjun Wu
Enable WM8731 to support common clock framework. Signed-off-by: Songjun Wu --- sound/soc/codecs/wm8731.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index 098c143..8df1550 100644 --- a/sound/soc/c

Re: [alsa-devel] [PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-03-01 Thread Bo Shen
On 02/16/2015 08:58 PM, Manuel Lauss wrote: On Mon, Feb 16, 2015 at 11:31 AM, Charles Keepax wrote: On Thu, Feb 12, 2015 at 04:23:06PM +0800, Bo Shen wrote: Hi All, On 02/05/2015 03:35 PM, Bo Shen wrote: Let the wm8731 codec to manage clock by itself. Signed-off-by: Bo Shen --- sound/s

Re: [alsa-devel] [PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-16 Thread Manuel Lauss
On Mon, Feb 16, 2015 at 11:31 AM, Charles Keepax wrote: > On Thu, Feb 12, 2015 at 04:23:06PM +0800, Bo Shen wrote: >> Hi All, >> >> On 02/05/2015 03:35 PM, Bo Shen wrote: >>> Let the wm8731 codec to manage clock by itself. >>> >>> Signed-off-by: Bo Shen >>> --- >>> >>> sound/soc/codecs/wm8731.c

Re: [alsa-devel] [PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-16 Thread Charles Keepax
On Thu, Feb 12, 2015 at 04:23:06PM +0800, Bo Shen wrote: > Hi All, > > On 02/05/2015 03:35 PM, Bo Shen wrote: >> Let the wm8731 codec to manage clock by itself. >> >> Signed-off-by: Bo Shen >> --- >> >> sound/soc/codecs/wm8731.c | 28 >> 1 file changed, 28 insertion

Re: [PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-12 Thread Bo Shen
Hi All, On 02/05/2015 03:35 PM, Bo Shen wrote: Let the wm8731 codec to manage clock by itself. Signed-off-by: Bo Shen --- sound/soc/codecs/wm8731.c | 28 1 file changed, 28 insertions(+) Any comments for this patch (aka ping?) diff --git a/sound/soc/codecs/

[PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-04 Thread Bo Shen
Let the wm8731 codec to manage clock by itself. Signed-off-by: Bo Shen --- sound/soc/codecs/wm8731.c | 28 1 file changed, 28 insertions(+) diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index b115ed8..ecd8424 100644 --- a/sound/soc/codecs/wm873

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-04 Thread Mark Brown
On Wed, Feb 04, 2015 at 11:45:29AM +0800, Bo Shen wrote: > Do you mean I send my RFC patch as the formal patch, and let other boards > which use the wm8731 to add clk object, am I right? No, we need to keep the boards working so we either need patches adding the fixed clocks for existing boards o

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Bo Shen
Hi Mark, On 02/04/2015 12:21 AM, Mark Brown wrote: On Tue, Feb 03, 2015 at 03:40:45PM +0100, Manuel Lauss wrote: On Tue, Feb 3, 2015 at 1:44 PM, Mark Brown wrote: +wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); +if (IS_ERR(wm8731->mclk)) { +wm8731->mclk = NULL; +dev

Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 06:26 PM, Lars-Peter Clausen wrote: On 02/03/2015 06:17 PM, Russell King - ARM Linux wrote: On Tue, Feb 03, 2015 at 05:53:48PM +0100, Lars-Peter Clausen wrote: On 02/03/2015 01:44 PM, Mark Brown wrote: On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: +wm8731->m

Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 06:17 PM, Russell King - ARM Linux wrote: On Tue, Feb 03, 2015 at 05:53:48PM +0100, Lars-Peter Clausen wrote: On 02/03/2015 01:44 PM, Mark Brown wrote: On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: +wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); +if (IS_

Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Russell King - ARM Linux
On Tue, Feb 03, 2015 at 05:53:48PM +0100, Lars-Peter Clausen wrote: > On 02/03/2015 01:44 PM, Mark Brown wrote: > >On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: > > > >>+wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); > >>+if (IS_ERR(wm8731->mclk)) { > >>+wm8731->mcl

Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 01:44 PM, Mark Brown wrote: On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: +wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); +if (IS_ERR(wm8731->mclk)) { +wm8731->mclk = NULL; +dev_warn(&spi->dev, "assuming static MCLK\n"); +} This is br

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Mark Brown
On Tue, Feb 03, 2015 at 03:40:45PM +0100, Manuel Lauss wrote: > On Tue, Feb 3, 2015 at 1:44 PM, Mark Brown wrote: > >> +wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); > >> +if (IS_ERR(wm8731->mclk)) { > >> +wm8731->mclk = NULL; > >> +dev_warn(&spi->dev, "assuming static M

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Manuel Lauss
On Tue, Feb 3, 2015 at 1:44 PM, Mark Brown wrote: > On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: > >> +wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); >> +if (IS_ERR(wm8731->mclk)) { >> +wm8731->mclk = NULL; >> +dev_warn(&spi->dev, "assuming static MCLK\n")

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Mark Brown
On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: > +wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); > +if (IS_ERR(wm8731->mclk)) { > +wm8731->mclk = NULL; > +dev_warn(&spi->dev, "assuming static MCLK\n"); > +} This is broken for both deferred probe and in

Re: [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-02 Thread Manuel Lauss
On Tue, Feb 3, 2015 at 4:33 AM, Bo Shen wrote: > Let the wm8731 codec to manage clock by itself. > > As all at91 related boards have been switch to CCF framework. So, on > the at91 related boards which use wm8731 will let it manage the clock, > or else the board use wm8731 is broken. > > However,

[RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-02 Thread Bo Shen
Let the wm8731 codec to manage clock by itself. As all at91 related boards have been switch to CCF framework. So, on the at91 related boards which use wm8731 will let it manage the clock, or else the board use wm8731 is broken. However, at the same time the wm8731 codec is used on other boards, I