On Tue, Feb 3, 2015 at 1:44 PM, Mark Brown <[email protected]> wrote: > On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: > >> + wm8731->mclk = devm_clk_get(&spi->dev, "mclk"); >> + if (IS_ERR(wm8731->mclk)) { >> + wm8731->mclk = NULL; >> + dev_warn(&spi->dev, "assuming static MCLK\n"); >> + } > > This is broken for both deferred probe and in the case where the clock > API genuinely returns a NULL clock. Other than that it's the kind of > thing that we've done for some other drivers, though it's not good to > have to do this. Check them for correct behaviour.
Hm, so the only option is to create the simples possible 12MHz clk object? Manuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
