Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

2015-04-08 Thread Caesar Wang
Mark, 在 2015年04月08日 17:50, Mark Brown 写道: On Wed, Apr 08, 2015 at 04:52:08PM +0800, Caesar Wang wrote: +static void max98090_i2c_shutdown(struct i2c_client *i2c) +{ + struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev); + + dev_info(&i2c->dev, "shut down device\n"); Remov

Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

2015-04-08 Thread Caesar Wang
Heiko, 在 2015年04月08日 17:25, Heiko Stübner 写道: Hi Caesar, Am Mittwoch, 8. April 2015, 16:52:08 schrieb Caesar Wang: To fix pop noise when shutdown,the pop noise during shutdown is the pmic cutoff power of codec without any notice. Signed-off-by: jay.xu Signed-off-by: zhengxing Signed-off-by:

Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

2015-04-08 Thread Mark Brown
On Wed, Apr 08, 2015 at 04:52:08PM +0800, Caesar Wang wrote: > +static void max98090_i2c_shutdown(struct i2c_client *i2c) > +{ > + struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev); > + > + dev_info(&i2c->dev, "shut down device\n"); Remove this, it's adding noise. > + > + /

Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

2015-04-08 Thread Heiko Stübner
Hi Caesar, Am Mittwoch, 8. April 2015, 16:52:08 schrieb Caesar Wang: > To fix pop noise when shutdown,the pop noise during shutdown > is the pmic cutoff power of codec without any notice. > > Signed-off-by: jay.xu > Signed-off-by: zhengxing > Signed-off-by: Caesar Wang > > Serien-cc: linux-ke

[PATCH] ASoC: max98090: add shutdown callback for max98090

2015-04-08 Thread Caesar Wang
To fix pop noise when shutdown,the pop noise during shutdown is the pmic cutoff power of codec without any notice. Signed-off-by: jay.xu Signed-off-by: zhengxing Signed-off-by: Caesar Wang Serien-cc: linux-kernel@vger.kernel.org Serien-cc: devicet...@vger.kernel.org Serien-cc: diand...@chromiu